From: Bagas Sanjaya <bagasdotme@gmail.com>
To: TGSP <tgsp002@gmail.com>,
rafael@kernel.org, len.brown@intel.com, pavel@ucw.cz,
huanglei@kylinos.cn
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
xiongxin <xiongxin@kylinos.cn>,
stable@vger.kernel.org
Subject: Re: [PATCH -next 1/2] PM: hibernate: fix spelling mistake for annotation
Date: Tue, 1 Nov 2022 19:45:54 +0700 [thread overview]
Message-ID: <55d9baa0-6ab2-63ff-51c1-57f379efff29@gmail.com> (raw)
In-Reply-To: <20221101022840.1351163-2-tgsp002@gmail.com>
On 11/1/22 09:28, TGSP wrote:
> From: xiongxin <xiongxin@kylinos.cn>
>
> The actual calculation formula in the code below is:
>
> max_size = (count - (size + PAGES_FOR_IO)) / 2
> - 2 * DIV_ROUND_UP(reserved_size, PAGE_SIZE);
>
> But function comments are written differently, the comment is wrong?
>
> By the way, what exactly do the "/ 2" and "2 *" mean?
>
Shouldn't the description above better below triple-dash (just
before diffstat)?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-11-01 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 2:28 [PATCH -next 0/2] Fixes to the hibernate_preallocate_memory() TGSP
2022-11-01 2:28 ` [PATCH -next 1/2] PM: hibernate: fix spelling mistake for annotation TGSP
2022-11-01 12:45 ` Bagas Sanjaya [this message]
2022-11-03 16:25 ` Rafael J. Wysocki
2022-11-04 7:31 ` TGSP
2022-11-05 18:09 ` Rafael J. Wysocki
2022-11-01 2:28 ` [PATCH -next 2/2] PM: hibernate: add check of preallocate mem for image size pages TGSP
2022-11-01 21:23 ` kernel test robot
2022-11-03 16:47 ` Rafael J. Wysocki
2022-11-03 16:57 ` Rafael J. Wysocki
2022-11-03 17:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d9baa0-6ab2-63ff-51c1-57f379efff29@gmail.com \
--to=bagasdotme@gmail.com \
--cc=huanglei@kylinos.cn \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tgsp002@gmail.com \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®