From: boris.ostrovsky@oracle.com
To: Souptick Joarder <jrdr.linux@gmail.com>,
jgross@suse.com, sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
John Hubbard <jhubbard@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] xen/gntdev.c: Mark pages as dirty
Date: Fri, 11 Sep 2020 10:41:47 -0400 [thread overview]
Message-ID: <55deef6a-4199-b003-b187-7e7c4d1725ff@oracle.com> (raw)
In-Reply-To: <1599375114-32360-1-git-send-email-jrdr.linux@gmail.com>
On 9/6/20 2:51 AM, Souptick Joarder wrote:
> There seems to be a bug in the original code when gntdev_get_page()
> is called with writeable=true then the page needs to be marked dirty
> before being put.
>
> To address this, a bool writeable is added in gnt_dev_copy_batch, set
> it in gntdev_grant_copy_seg() (and drop `writeable` argument to
> gntdev_get_page()) and then, based on batch->writeable, use
> set_page_dirty_lock().
>
> Fixes: a4cdb556cae0 (xen/gntdev: add ioctl for grant copy)
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
Cc: stable@vger.kernel.org
(can be added at commit time)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
prev parent reply other threads:[~2020-09-11 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 6:51 Souptick Joarder
2020-09-06 6:51 ` [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*() Souptick Joarder
2020-09-11 14:42 ` boris.ostrovsky
2020-09-29 12:09 ` Souptick Joarder
2020-09-29 12:30 ` boris.ostrovsky
2020-09-30 2:14 ` Souptick Joarder
2020-09-30 14:10 ` boris.ostrovsky
2020-09-11 14:41 ` boris.ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55deef6a-4199-b003-b187-7e7c4d1725ff@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®