From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C3AE1361; Mon, 10 Mar 2025 09:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598122; cv=none; b=O+J5Lm32DhCYEyvxnvHuTt837MID2q96bnBgNHweEAExflQYCDVGQaOWsb0S4qzsBRooGzL7eWKmOTdk+J5v3RNXhlAAdDNlaenWSuJEorH8H5GgHDwv9Q9AASLOzGtsI7GPacoxS2BTkfoQCyoyKFYrjQG+GFk2oR71HF+2pt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598122; c=relaxed/simple; bh=XdSb86AZgBBvCfKshDgW/RerWUgRLdy+SuiU+8N73CQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=iMpkNjK+W070LOVQ9wbB2o5E4wTJZHcXPbeMoP2gFXfxMt7PdSFl2iPPVo0aIg51uoGgQrPqfM544mjx/pz/L3gJjiu4Cl0WS+mwYoRkfVLraXq7vdGSDMv2p2XFwURMbsar/YMElWBUhaJB2FRWqTmnshx/lN1s96m9CXqI/ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Ri0b0wyF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Ri0b0wyF" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 529La2gE014060; Mon, 10 Mar 2025 09:15:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= emCEPnGAgBEvgFMwBTfT/bBd93PEBF8nxLoLKxqgSSE=; b=Ri0b0wyFa9ury9oV 2QBOGDT7Dj48KSkhAnsGyolHYYOZemWGzPp4SB9wWIWja+GncMWfxQWzgffWTKuR 5u2cUnjR2Gmuozvdwg6VxISgk0tBSb3ZvKJcDeb3Sd8uDdYrQJoTgZfzsRgB+rxi gnPkTsflpotERgRmhApI/n2s3jBdM9sEPz/uCrjqln7IleNS6RYk+ynmHN0brKiE 7wC0ETskiUTFa9aTFaqaHx7oK+0eulWWxrJUfI6BW+ZQBR/Tug5zI5RcGUJqAkVS cxcAQnuayVxqSUZjMg6YFts6kiszfxGwxNCh0PwC4Sut/RDw8j16D6i+EfWQmSin jlK0lw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 458f2mc8t5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Mar 2025 09:15:05 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 52A9F43f011069 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Mar 2025 09:15:04 GMT Received: from [10.64.68.153] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 10 Mar 2025 02:14:59 -0700 Message-ID: <55e62062-f85f-484d-b577-87e10e73ab31@quicinc.com> Date: Mon, 10 Mar 2025 17:14:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] coresight: tmc: Introduce new APIs to get the RWP offset of ETR buffer To: Krzysztof Kozlowski , Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio CC: Tingwei Zhang , Jinlong Mao , , , , , , References: <20250310090407.2069489-1-quic_jiegan@quicinc.com> <20250310090407.2069489-2-quic_jiegan@quicinc.com> Content-Language: en-US From: Jie Gan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Bx8FOf-cxt4eCrRdwCyPwLGbAr0Djaq2 X-Proofpoint-ORIG-GUID: Bx8FOf-cxt4eCrRdwCyPwLGbAr0Djaq2 X-Authority-Analysis: v=2.4 cv=ab+bnQot c=1 sm=1 tr=0 ts=67cead99 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=Con8ddXmaDJE1B7ER5wA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-10_03,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=697 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503100072 On 3/10/2025 5:07 PM, Krzysztof Kozlowski wrote: > On 10/03/2025 10:04, Jie Gan wrote: >> +static long tmc_sg_get_rwp_offset(struct tmc_drvdata *drvdata) >> +{ >> + struct etr_buf *etr_buf = drvdata->sysfs_buf; >> + struct etr_sg_table *etr_table = etr_buf->private; >> + struct tmc_sg_table *table = etr_table->sg_table; >> + long w_offset; >> + u64 rwp; >> + >> + rwp = tmc_read_rwp(drvdata); >> + w_offset = tmc_sg_get_data_page_offset(table, rwp); >> + >> + return w_offset; >> +} >> + >> +/* >> + * Retrieve the offset to the write pointer of the ETR buffer based on whether >> + * the memory mode is SG, flat or reserved. >> + */ >> +long tmc_get_rwp_offset(struct tmc_drvdata *drvdata) > > You need kerneldoc for exports. Hi Krzysztof, Sorry for the insufficient description for an export function. Will fix it in next version. Thanks, Jie > > > Best regards, > Krzysztof