mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tharunkumar.Pasumarthi@microchip.com>
To: <wsa@kernel.org>
Cc: <UNGLinuxDriver@microchip.com>, <krzk@kernel.org>,
	<arnd@arndb.de>, <andriy.shevchenko@linux.intel.com>,
	<robh@kernel.org>, <semen.protsenko@linaro.org>,
	<sven@svenpeter.dev>, <jarkko.nikula@linux.intel.com>,
	<linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<jsd@semihalf.com>, <olof@lixom.net>, <rafal@milecki.pl>
Subject: Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch
Date: Fri, 23 Sep 2022 13:51:52 +0000	[thread overview]
Message-ID: <55e6769b1d7e890f4211b44f821b11654a5b9f4d.camel@microchip.com> (raw)
In-Reply-To: <YyY1vESf5JalT6GR@shikoro>

On Sat, 2022-09-17 at 23:01 +0200, Wolfram Sang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> If you can't do I2C_FUNC_SMBUS_QUICK, then you need an i2c_adapter_quirk
> struct saying that your HW cannot do 0 byte length transfers.
>
> Also, a lot can be simplified here, e.g. I2C_FUNC_SMBUS_BYTE covers both
> cases, read and write.

Okay. I will update code.

> Why not use then simply 0 instead of a define and a comment?

Okay, I will update.

> I need to make sure: do you intentionally want autoprobing for SPD? I
> ask because it could be needed but it costs boottime when not needed.
> And changing the class once exposed is troublesome.

Autoprobing is not required. I can modify code. 

All these comments need to be addressed now or can be fixed later after the
patch is applied?


Thanks,
Tharun Kumar P

  reply	other threads:[~2022-09-23 13:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 16:11 Tharun Kumar P
2022-09-07 16:32 ` Andy Shevchenko
2022-09-16  9:04   ` Tharunkumar.Pasumarthi
2022-09-17 21:02   ` Wolfram Sang
2022-09-17 21:01 ` Wolfram Sang
2022-09-23 13:51   ` Tharunkumar.Pasumarthi [this message]
2022-09-23 16:24     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55e6769b1d7e890f4211b44f821b11654a5b9f4d.camel@microchip.com \
    --to=tharunkumar.pasumarthi@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=krzk@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rafal@milecki.pl \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=sven@svenpeter.dev \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®