From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAAA1309F1B for ; Sun, 22 Mar 2026 00:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774139992; cv=none; b=K3CuFFk6v39scfjqGHqY+T6wwEjB62MF+OatGdjv5VHEVVHa3+QJ52o9Yg04bILxutIrxyT4CAB5xLAvbKzaU2bNy3EbVd562NPTt55pApspaS4a8zE6rjINKa90vk559xv9uJoXqFU8Y+g8TWXE5VuHEXfwt8w0xyToYjF9hrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774139992; c=relaxed/simple; bh=CL2yetUDApoUW5IHkiVF7crdPEfYmediFopWU4E+gZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rVO5HK13r9gLhkN5a+mvza1PhALudJ5pmTyrQ+weQYXX2JHgn6dho/3Hp2xNE0yg0raRbXEk7hhsOsqHwJZVN0pG1Cg5fHugvkFCrfdKcpYnnU2R0dFUMbMnaPaHA+8IU3Y5OdPHlAO7iYBbT9Q4falP+gVFhFNvM1RsOPum/UM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mo85NOFu; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mo85NOFu" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d743cd9e5bso2104650a34.2 for ; Sat, 21 Mar 2026 17:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774139990; x=1774744790; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q67F6wsbJFmv8Xdsauv+9sKsKQWsiG7VuUuAqPJNxsQ=; b=mo85NOFu2koCIh8R6GjhxiklarmpC7Ooaqn6Id2SIRXAWP12aQAPo/DJbwRT5UR5jD rIIOr7fmURKluZkiLPrRL385BsCHqhElrLeTCxBXEnJo9gjK9iMsFP7lP9uYvpjLIWwR dXrNgkMhneoVPBjcUYutjKY1dyUU/cHY5EeIevYhL8T1gK2VcQU44FH3EH/2YjocOf1W WmRAzZu/WcNE4X/9zpiCaMk0Gu8J8eDKkx1NUfYusUuKKo3xc6VWdlGCTFv5FmzX9yOh hxmNQKUqRLVMOMaIQ405eJUUuviwivU7VYhuFhZPlvW3RJQKswkJXttEnWZV1dXLLcWT 9Fsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774139990; x=1774744790; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q67F6wsbJFmv8Xdsauv+9sKsKQWsiG7VuUuAqPJNxsQ=; b=QhmWcAfjrUanVnzV5Mj7Al9fiKX2VNs5hCFcjysJ6BDZNJTkkCtB7NGQy414UqJoS4 6mJktNVcXYHYIp/MpBFahgzQ77O3w9hjAlyOIU/KQtB1xwf8MBHCHloqNiWYv5e6Yyrx Amefh1LehT11rZo3vvQT1QV5638WH4dWaSP1DzdZssOCUQAUmetPsBYi9GGAZNqVrEVH /rRUcySizOrj1vnif8qBlHDMxz5ufJnPr7zvTfQhg0JoDm/3DHkzNTPfPkWqKCz2kgSy dMgr5ES3wH7WAMh8YgEmgpNr8wjhWRBzYUnzPDHwMzVE6o6YSUm+s2mVCQwN4QTwr7+C XVZg== X-Forwarded-Encrypted: i=1; AJvYcCXwxsyNLFFk8VpXc//a985Kq+tqeYiazKyU1Yz8GbtHIqbFadVkmHQt9j0gc7dk97ANWfOYHkCPGX9gDkI=@vger.kernel.org X-Gm-Message-State: AOJu0YwxvHpsNVScq3F3jgLDEdnph2L5UlTy6LbHlVMY8+y+5zl2uy6+ 4Gmms6iffY3pJVDvFftApaFDJN7mNPoDtfwSY+Sc+k1vGTj8LYXCq8UZr633qJr/62W0GLvC77h dgZWP X-Gm-Gg: ATEYQzx9E4JO9CH1seLIjhJGzRs+BYTbJf1207uEnSEuf5jiw7i1paYSd5xmgszka1R Fc0EMSLOxdjKjtSy6fjfOdeHaZsVhUUVhwSCA3H809fwXKgjaq0pqeg7H/1domobk7UKgnvF8o9 n59w2YwYrFjUkNnt/p+9Uw1wwiu4nyMJMRnb03Byfy4/WEz1fd/2S1B0q/sVuy3lEJZbZg2lhBa Qd1UZAAmzLlqw0JWRriVVC805yt5/piFBIsrsX3zJLAkRpBqbVzGEqe6v92N4vi70Pf3rjp8x3u GmhCxEiM/qFgDUSwVYzxIcvU4Go0GPLORErUdHY3tKALBBXjsnYrQ8NsKSMXh2rMExw5dX+w4hv pEjQ60IDYTQNSswVopvWMMWewrsz/stFf6r20nlk3nOubZlpAt57cA5OFRkDpTrzqUWtZO/r7Hw J+cD2MzXJSDfom7tNhkMWMPT90H2fN3eqDFQ9qXU/2N15kRvBFQwrVveGGsH3tyyDaMbhvnmo= X-Received: by 2002:a05:6830:7317:b0:7d7:bf70:af2 with SMTP id 46e09a7af769-7d7eae1c92dmr5186748a34.1.1774139989828; Sat, 21 Mar 2026 17:39:49 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:fb84:df2:aafb:553d? ([2600:8803:e7e4:500:fb84:df2:aafb:553d]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d7eadfc678sm5832938a34.19.2026.03.21.17.39.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2026 17:39:49 -0700 (PDT) Message-ID: <55e92148-b5de-4fb8-af0b-9476235341bc@baylibre.com> Date: Sat, 21 Mar 2026 19:39:47 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor To: Sirat , Jonathan Cameron Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260319190738.151614-1-email@sirat.me> <20260319190738.151614-3-email@sirat.me> <20260321172151.1f434680@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/21/26 6:40 PM, Sirat wrote: > On Sat, Mar 21, 2026 at 11:22 PM Jonathan Cameron wrote: >> >> On Fri, 20 Mar 2026 01:07:14 +0600 >> Siratul Islam wrote: >> >>> Add support for the STMicroelectronics VL53L1X Time-of-Flight >>> ranging sensor with I2C interface. >>> >>> Signed-off-by: Siratul Islam >> Hi Siratul >> >> Just a few minor things seeing as you are going to v7 anyway. >> If you weren't I'd have applied some or maybe all of these as tweaks >> whilst picking the driver up. >> > No problem at all. >> >>> diff --git a/drivers/iio/proximity/vl53l1x-i2c.c b/drivers/iio/proximity/vl53l1x-i2c.c >>> new file mode 100644 >>> index 000000000000..771598b92e04 >>> --- /dev/null >>> +++ b/drivers/iio/proximity/vl53l1x-i2c.c >>> @@ -0,0 +1,820 @@ >> > --- >>> + /* >>> + * vdd-supply is required in the DT binding but we >>> + * continue if it is missing to support older DTs. >> >> Given the driver does nothing different for an auto provided fake regulator >> and one from DT, I'm not seeing the comment as particularly useful. >> >> Drop it. >> > Considering there is zero difference between the fake and real regulators > in terms of functionality of this driver, should we just drop the hard > requirement in the binding? No, bindings should not depend on driver implementation. >> > > Thanks, > Sirat