From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45421E495 for ; Tue, 22 Oct 2024 12:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729598731; cv=none; b=ZVtBYJPGacy+veKMSjL/aXoJHB8R1jU1N4Hv8wtjAJ9mMYGgnGqNJaJ7mYqimA/w4U23L2/NnjesZ5YBvfj4Sxxo600KsfoLkYk5sqnd3hYiLGQ6FSJifcoVkYUZfXJeAPEePszHR5JhQ1qY+tb4WbyliZ5tcjUMoLQ35V1Il/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729598731; c=relaxed/simple; bh=xAa35UEgyalTFRei9YaqIbZpH4Vbt4ugEAjxJ/AXAGU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kshR2KOI1M7JTnzCjvaqTW+4ymUdQu5A5yRPOP7Y6UxPUO8mzUNypPAYhLVXImdhhA7Ux+hvmzrqa2RxyOYbh5bOp9rj1fUKtFtBD/0/kItoJCZyc9DEgNVRRcsGXGsxce0vpoMi1wqlxMkvtK9UQdW/c2oL915w00+2i96oDaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=opJmI1l8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="opJmI1l8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43161c0068bso41298645e9.1 for ; Tue, 22 Oct 2024 05:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729598728; x=1730203528; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=d+rXM8YoCxSlmKFLltL+X2lgjTLpMqtyIwjJXBbz9u8=; b=opJmI1l8JCSPoha6axU22ENcj/I9GLB8GQR2xF35QQ6hI4tAbCBi3DTbN+WXG2PQMg nkmwcuv89hwFZTRUspKdKlDPgA49v/ktEw+40EUK/sgi+7votArWLJIXqP9gOZeI6VUa fidgjQhbfXSy6tYc22fHfd2zJ6xgD3+TcY9P8DcUkEm37qGCyBhwdViegL2yWkX4jg1S 28k/Fs2qLDvjbtsRElaz4Qldgay1jXyDwSfoeq7FhjAv/SKuhGzUBaaBv+o3FPpfuQlA wgh+isG3Hpo+jNqStsFOVti3swwr51w2RdhD1mFR7J3BmJNQ+A3jqnPnByujjS7AHkTV EP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729598728; x=1730203528; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=d+rXM8YoCxSlmKFLltL+X2lgjTLpMqtyIwjJXBbz9u8=; b=RuV8/CDCBGfEwnfqy/bBKfVyvO7kMFCHz/LlOrcfYvDjF6q7qQVC+5oNpZEu3w532w Csn0JeJAmamGyaGdNJwxURoqzW3Tiwhb0zQwpOaxj01rxXaBMASMSWBwhPM4xoal+ML3 4mQzkqteUIjgEYZp1oU9byVkldOv2JHHK+/DkOLII5ifj099P/vdLDKgJmFj1xHbDUch 5Y8GExyJpQTvUWJi0Mvx8/5QINp43LV01UNTbMzljSRZmnzUTZb154WoEs1V9VGEzdUE DTVRUiw6lKYL8ucZmCRmXzhOByoVmmgvhReIq5MGQDd+8SDevCMDqGM/FH18egWSNy9v H//Q== X-Forwarded-Encrypted: i=1; AJvYcCWmqtk4nJAkHgu/zGVNkRK7z9Njc7GgFXOj/GDNvyB82OdUig6Vw6vTAh+7624/vQAZN9hkrsPoxaBZHNo=@vger.kernel.org X-Gm-Message-State: AOJu0YzX//VIXnzxTVQw6zpmdrzH32lfNOvaXaCzhdEC9+/oLsO/2C8K CSpI9mrPtE4wL1H6tFl1cT1x0CPoeVXZjluWRnwYU2iQrVszQHRWk7Xzf3HDbZU= X-Google-Smtp-Source: AGHT+IGOriYXOUTnFe0hK1xqAhG0+iTqWnSOGWteduSyNyhKdpHlOzUZIu4+hZqVlkKxd/tYNb98/g== X-Received: by 2002:a05:600c:4e12:b0:431:4f29:9542 with SMTP id 5b1f17b1804b1-431616332a7mr122094945e9.6.1729598728173; Tue, 22 Oct 2024 05:05:28 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:43af:403f:2c26:9ea7? ([2a01:e0a:982:cbb0:43af:403f:2c26:9ea7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a477d9sm6494001f8f.26.2024.10.22.05.05.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 05:05:27 -0700 (PDT) Message-ID: <55ecee09-196a-4c7a-b7cf-61c19737735b@linaro.org> Date: Tue, 22 Oct 2024 14:05:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] i2c: qup: use generic device property accessors To: Bartosz Golaszewski , Andi Shyti Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20241008160947.81045-1-brgl@bgdev.pl> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241008160947.81045-1-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/10/2024 18:09, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no reason for this driver to use OF-specific property helpers. > Drop the last one in favor of the generic variant and no longer include > of.h. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/i2c/busses/i2c-qup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index 86ec391616b0..da20b4487c9a 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -17,9 +17,9 @@ > #include > #include > #include > -#include > #include > #include > +#include > #include > > /* QUP Registers */ > @@ -1683,7 +1683,7 @@ static int qup_i2c_probe(struct platform_device *pdev) > } > } > > - if (of_device_is_compatible(pdev->dev.of_node, "qcom,i2c-qup-v1.1.1")) { > + if (device_is_compatible(&pdev->dev, "qcom,i2c-qup-v1.1.1")) { > qup->adap.algo = &qup_i2c_algo; > qup->adap.quirks = &qup_i2c_quirks; > is_qup_v1 = true; LGTM Reviewed-by: Neil Armstrong