From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Ruidong Tian <tianruidong@linux.alibaba.com>, coresight@lists.linaro.org
Cc: mike.leach@linaro.org, leo.yan@linaro.org,
alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: perf: Release Coresight path when alloc trace id failed
Date: Tue, 25 Apr 2023 10:14:44 +0100 [thread overview]
Message-ID: <55ed1d19-cce9-b9b0-30d6-21b5ee3e5fe9@arm.com> (raw)
In-Reply-To: <20230425032416.125542-1-tianruidong@linux.alibaba.com>
On 25/04/2023 04:24, Ruidong Tian wrote:
> Error handler for etm_setup_aux can not release coresight path because
> cpu mask was cleared when coresight_trace_id_get_cpu_id failed.
>
> Call coresight_release_path function explicitly when alloc trace id filed.
>
> Signed-off-by: Ruidong Tian <tianruidong@linux.alibaba.com>
Good catch, I will queue this.
Thanks
Suzuki
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 711f451b6946..89e8ed214ea4 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -402,6 +402,7 @@ static void *etm_setup_aux(struct perf_event *event, void **pages,
> trace_id = coresight_trace_id_get_cpu_id(cpu);
> if (!IS_VALID_CS_TRACE_ID(trace_id)) {
> cpumask_clear_cpu(cpu, mask);
> + coresight_release_path(path);
> continue;
> }
>
prev parent reply other threads:[~2023-04-25 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 3:24 Ruidong Tian
2023-04-25 9:14 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ed1d19-cce9-b9b0-30d6-21b5ee3e5fe9@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=tianruidong@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®