From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ayaan Mirza Baig <ayaanmirza.788@gmail.com>
Cc: kernel-janitors@vger.kernel.org, ayaanmirza788@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Subject: Improved help text for rtl8712
Date: Wed, 6 Mar 2024 18:15:22 +0300 [thread overview]
Message-ID: <55ee3fe0-d80d-4880-a171-33a044e95078@moroto.mountain> (raw)
In-Reply-To: <b442a768dd23d9c6fdac6fcc30bc86794e85c8f5.camel@gmail.com>
Hi Ayaan,
This patch obviously got a bit mangled in transmission as you can see.
Read the first paragraph of Documentation/process/email-clients.rst, but
then do a google search on how to use git send-email. Send patches to
yourself until you figure it out.
After that use scripts/get_maintainer.pl to create the correct CC list.
On Wed, Mar 06, 2024 at 08:15:35PM +0530, Ayaan Mirza Baig wrote:
>
> >From df9050d0dff9e4160172dbc910f718c16095fc8d Mon Sep 17 00:00:00 2001
> From: Ayaan Mirza Baig <ayaanmirza.788@gmail.com>
> Date: Wed, 6 Mar 2024 19:53:12 +0530
>
> Rewrote the help text paragraph for R8712U and R8712_TX_AGGR
>
The commit message needs to say what wrong with the original help text
and why you are re-writing it.
I suspect that you're re-writing it just to make it longer than the 4 (?)
line minimum. Don't bother with that. Checkpatch is overly strict.
People can understand the help text fine even though it's just 3 lines.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-06 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:45 Ayaan Mirza Baig
2024-03-06 15:15 ` Dan Carpenter [this message]
2024-03-06 15:16 ` Dan Carpenter
2024-03-06 15:43 ` Ayaan Mirza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ee3fe0-d80d-4880-a171-33a044e95078@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=ayaanmirza.788@gmail.com \
--cc=ayaanmirza788@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®