From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E09CC05027 for ; Wed, 8 Feb 2023 19:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbjBHTvJ (ORCPT ); Wed, 8 Feb 2023 14:51:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbjBHTvG (ORCPT ); Wed, 8 Feb 2023 14:51:06 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FE721C7CA for ; Wed, 8 Feb 2023 11:51:05 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id y1so17967098wru.2 for ; Wed, 08 Feb 2023 11:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cY1HwE63r9UqyW6Gdx6yhcFxmTguDnqyz+SAe6KoqOQ=; b=Hn2pHT7CPTC3o8c4Wpog/hsIQx7uvafsHgvOxeofLCyAJV9L7gPsNScf3TeLdqqPnr LUzNnDUuUwSEk4aAlXxfEaM0zrMXnNq/Cz9jO8mHY2YrfNr8ZSfgFLz3JafNViK1B0bT 53rAEhyJo2OFPoJrvYYNaSFu+AOUT2z3hE6WS4W+99iNSs+K++NUxAAHsqs+vnQswru7 g2c2FQ5Zbky3mbyXl60E6JmICG07hRBCes7yafGv0Boq39tw4NTKpnaCMM8GPAJALkiJ IzP9WQ7KcVyZ+MritmxJAz+n/lPp2+TSmLh2MLkT3IRzrHIZ1barAg2zteWvZOip25aT bkXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cY1HwE63r9UqyW6Gdx6yhcFxmTguDnqyz+SAe6KoqOQ=; b=xkLe2fNNE8IoukYs2tHDW//2JJFfT3mBz0jCMTm10GDC+x00BtUQH7kEeDwY1H026+ d14ejN42+0fovmrkQjTw/rC0AtGYfGrHnpcTaTvBdwv6bH2Xbf41YQGXZavP/HwrRfz5 FMrTBNYHnAveTCdJnmJZ+lZNwm875sawSjhBH7wFnyVvXaih5rzHRyi77Rn3kQ/IgKLz gO13oFRP8X3dqcFRRtrVN0jRKEQU/ZoNhiU07yPi2oyHpR09wtxvmlq+K5cb5TSG/R+L aHI13/I93lT5Qid/cSVMatF3mSvhlx4U2ZEayUcWUGk1kERCjq3kMdG4E1S1vAMXGmrP R3MA== X-Gm-Message-State: AO0yUKU83L2EY8NzTJkCeopTzd4hEUmfc+Hfqfy3dprZANTJKvlIpsBD ARcQKD0uX41ALOGqwYGyaUoPDg== X-Google-Smtp-Source: AK7set9dhkugBafQNUYIvCX0R36B8oLdf4eHcflcqRkwcR7SGvh653bV+4HiKahZLc+dRe/stewv5A== X-Received: by 2002:adf:ef0d:0:b0:2c4:645:da36 with SMTP id e13-20020adfef0d000000b002c40645da36mr2643620wro.24.1675885863619; Wed, 08 Feb 2023 11:51:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f9-20020adff989000000b002c3e6b39512sm8933760wrr.53.2023.02.08.11.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 11:51:03 -0800 (PST) Message-ID: <55f02cd9-d191-8454-ef67-613bc8373f9f@linaro.org> Date: Wed, 8 Feb 2023 20:51:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH net-next v2 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Content-Language: en-US To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , Wong Vee Khee , Kurt Kanzenbach , Revanth Kumar Uppala , Tan Tee Min Cc: Thomas Petazzoni , Herve Codina , =?UTF-8?Q?Miqu=c3=a8l_Raynal?= , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Mohammad Athari Bin Ismail , Jon Hunter , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20230208164203.378153-1-clement.leger@bootlin.com> <20230208164203.378153-5-clement.leger@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230208164203.378153-5-clement.leger@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2023 17:42, Clément Léger wrote: > Add "renesas,rzn1-gmac" binding documentation which is compatible with > "snps,dwmac" compatible driver but uses a custom PCS to communicate > with the phy. > > Signed-off-by: Clément Léger > --- > .../bindings/net/renesas,rzn1-gmac.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > new file mode 100644 > index 000000000000..944fd0d97d79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas GMAC > + > +maintainers: > + - Clément Léger > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + required: > + - compatible > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + - snps,dwmac This is still not correct and does not make any sense. What do you want to say here with such binding? That you describe "snps,dwmac" here? Then it's duplicated with snps,dwmac.yaml... Drop that enum and make it a proper list. Best regards, Krzysztof