From: Markus Elfring <Markus.Elfring@web.de>
To: Tejun Heo <tj@kernel.org>, Chen Ridong <chenridong@huawei.com>,
cgroups@vger.kernel.org
Cc: "Aditya Kali" <adityakali@google.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Serge Hallyn" <sergeh@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [V4] cgroup/cpuset: Prevent UAF in proc_cpuset_show()
Date: Sun, 30 Jun 2024 20:00:52 +0200 [thread overview]
Message-ID: <55f0bd69-03a6-4a2f-94e0-6c62e2e3a6f8@web.de> (raw)
In-Reply-To: <ZoGP6uV2oD4AdYWP@slm.duckdns.org>
>> Under which circumstances would you become interested to apply statements
>> like the following?
>>
>> * guard(rcu)();
>> https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/rcupdate.h#L1093
>>
>> * guard(spinlock_irq)(&css_set_lock);
>> https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/spinlock.h#L567
>
> I don't really care either way.
I find such feedback interesting somehow.
> Neither makes meaningful difference here.
Would you like to support making the affected source code safer and a bit more succinct?
https://elixir.bootlin.com/linux/v6.10-rc5/source/kernel/cgroup/cpuset.c#L5034
Regards,
Markus
prev parent reply other threads:[~2024-06-30 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 1:36 [PATCH V4] " Chen Ridong
2024-06-28 17:11 ` Tejun Heo
2024-06-30 9:20 ` Markus Elfring
2024-06-30 17:03 ` Tejun Heo
2024-06-30 18:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f0bd69-03a6-4a2f-94e0-6c62e2e3a6f8@web.de \
--to=markus.elfring@web.de \
--cc=adityakali@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=sergeh@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®