From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2562F34B40A for ; Wed, 17 Dec 2025 10:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966117; cv=none; b=fQC3a4YmPc4ZRfGU7MnEj33VJEPed7dJq5TKSKJYt1HP26F+k4igkSnEeYwVJqy6L7RoSMI84G59HIVYIWbwvp8tVKgExYjQN+xwwAvz+QsPiZJHFcpQVsXfQJUxuirH51HeSayl4GaUDjxF1OXXdzlBWr9Lqi75GFKdVyQ3uWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966117; c=relaxed/simple; bh=e03yN4PSC1w6aBbtPzvDebOeR75CPTHswZIO3lmyqK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ERTeSv4IhLfzzDekwvunMoylM5I/q8KWi0b6ixPy9Ga2uHMVFxTdRlToO+5DtTS/FtdJbTX0F5oSHWhBnYsKjtcRBQgKUU1coPW3dCaYT3BbmEjnLIXsaOyg6o8pkOzwO+X2f60aJlkd+99DJZ8fqIHxgDnyxuIq31URVdQa2Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SNcJ6Z5j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GlqPGPOB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SNcJ6Z5j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GlqPGPOB" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH9w5YO870098 for ; Wed, 17 Dec 2025 10:08:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ob1B7GC3z4Hye/c8cOiOMchvI+sRX/aL+C4QZ7XJJzk=; b=SNcJ6Z5j2SqaeOrM zBR9APL/cLu3cj4BydHd5XnRl5LYK9FIRWnI/09VQ4gdTlQ8/Cq9E8R0vSog5gYU WwkPK0ponZDxwnT4D8Q3Z+4dfjYeH9mToh+qlT82miy23RbPP9YB+4uZ6yiTY+0D MpN9+YGV+P0qxVETo8oAku5Osgo9YbxkhQz3yfwzLM93ibgASVA+jFOgUbk9YuLD nO24jelVyzBEXdqi+GutrHq943QCoDj6T0zKu1Xz/iIcnVmFyP0YjymVUsjeqaCD r56N9Hts/fVVt3uPKff5W2AeR/aswk3BnNPGDEr+3Ook5DKnJN/CIPz0KIWJnonq Iuexjg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3fj1t0kf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 10:08:34 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b5edecdf94eso10082587a12.2 for ; Wed, 17 Dec 2025 02:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765966113; x=1766570913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ob1B7GC3z4Hye/c8cOiOMchvI+sRX/aL+C4QZ7XJJzk=; b=GlqPGPOBtfDdCIjeydILc+78sLal1LeqaPVPT8FN2a1p8jmtTHcDC6qP7uJOjGeeVW 6NdN3YBog5b7AFEdMbJEy3Wigc9oAQ8vsxEJREVBVWUbvR0/SLMOA0vrqeVUzmhhOH00 sGyDhd9q/nk08+cwPn2DKWZXYpFp79bCwp0SOOSbZro/NDQSKlvdB5NmLdOsT3gvlADA uhDqjI67mKXfX2N9KjzA90kseAQwxhWohlgv8gKKTcDApKTQBzjTRcR5duEay3aYmAEj leFmWQJYhQr3mU/RIFxrs8QywgeaSEc2V8f2XP29kZJ9KKsxoXJOjBniCd7juVykgbsQ sNag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966113; x=1766570913; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ob1B7GC3z4Hye/c8cOiOMchvI+sRX/aL+C4QZ7XJJzk=; b=Hj5GMni25WNI8cHOXisVtN8EUmwO9qv/9cqnhpRYUJJ/xdNDUYzoWx/+EP2wAOXWcc 8TMRBmnTiisLuzVp9TTLunlWi6Yr8DgSBU2OBTgbdAJq+pN76vw2v2nXYDxi0v7M3Upj +p/ogvdYDX7X7ciHby3fJSP5kSf6EgVKLWzEqvsbFXiHVqL/clnvuOAWKWVThpER5wrv MYL5cTPoX4fU36UmMqnWcgWJfsEfVw21TJdJ7Dd0+UJr2qgx/FvR37Os3/xIIPWxbLwo dM4mw+i9M7ItGxznpDxlR1zrW327nxvb4rEj5HcULPEPTRQhqZ0QaYTm6WdZdzKnLK39 ze3Q== X-Forwarded-Encrypted: i=1; AJvYcCVkbGkzAkSS6ZiinG41cv9qeRwuP1FqCiHcvgltd2iWwGDoKdXjt0aNJAHeNHV6SkOtcxcH24ul6BfKcJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YzKrQ9uRhvPqbObT8AAAOyPdVkyx52QYckZtOH8TtHwFmBhNH/1 I61E4t+N+f6/sTytfV1vKUB05dX4ALn/YWYd6TQkaF/tJ+aFAnVn6BfL2P4YHtbCtJ4ItO780aA rJeV0AAUaVQB2uLP8m2XCqD88jDUEVZ58eX3CEa8pHxaypQDjNtKUWy49K68JrozMMzk= X-Gm-Gg: AY/fxX4C83HVaPgKTnoqLFT0UUFJYobfzTxNojtqHGxz3VxCxuZoNjVReLdIBIDDxsp KVpi6eOPQC3g0CFqAUwkjEUmO1TH5lSCVKxWYqzocE9Vez0feA1E2PHWWIIS1p+aJ8g6zZkSupQ u23P03hcdKLeLLZ+PsKkN/t5tfT4CwXFD1BdBs/HHjiQoYYkTifQoCozFtp/kgRd4UO6BYAqten KFiDTO8ODr2pURfw+RafVW60GXY7UrohXnQF6wwteAtif1phlP3IOBi+WdxwW4JkgFYbFJRTHZD 3cj7ZVZ6nzsSVCmXR95p+mTNfT1oCP56dM6wSKM/ilu7x3JVhIe8Zz7LYPubq1fbtkwvg/+6S2J WZIFfJEefrVC7qKEBGOpIu2/qZD4A51mUPu1uuJ3fEw== X-Received: by 2002:a05:6a20:7fa3:b0:361:2f3e:cac2 with SMTP id adf61e73a8af0-369ae7766a2mr18899033637.33.1765966113378; Wed, 17 Dec 2025 02:08:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3QmyjSiMweA/arYt/8VUm5ViMFMTTEaOxXTtRy2plCGXPaoJUh9fBxLm1FZMRzWIkrWhcMg== X-Received: by 2002:a05:6a20:7fa3:b0:361:2f3e:cac2 with SMTP id adf61e73a8af0-369ae7766a2mr18899007637.33.1765966112887; Wed, 17 Dec 2025 02:08:32 -0800 (PST) Received: from [10.204.100.70] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c2ae4e163sm17636576a12.20.2025.12.17.02.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 02:08:32 -0800 (PST) Message-ID: <55f68c6f-9b7e-4393-9ca2-b94551cd81b8@oss.qualcomm.com> Date: Wed, 17 Dec 2025 15:38:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 00/14] Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2 To: Dmitry Baryshkov Cc: Bjorn Andersson , Mukesh Ojha , Bryan O'Donoghue , Bryan O'Donoghue , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> <0156c327-b867-481e-af24-679f037bfa56@linaro.org> <20251121113751.tnqw5abm5sd2rgr7@hu-mojha-hyd.qualcomm.com> <9dfe5343-824d-42c2-aab8-8389602601e9@kernel.org> <20251202083650.luk2jpcquq2pcf2r@hu-mojha-hyd.qualcomm.com> <623225c2-166a-49a1-9856-d02ed55f1e47@oss.qualcomm.com> <64dbe824-a94c-4394-8cbe-ebdb7a3c42fd@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA4MCBTYWx0ZWRfXz73//kpKE5qI UZAc0ySaZXwAhnq9nY6pRX5JOKJbFR7LSPnprn8B4dNeI8nK3jByGDwgfgawKiBou1Xb2wbkSBx u3ux0TUW06CZUP2XC65nPxJprsCYt7cMRyBa6yYnznJteCxMN+arKddRjD4Fd16UKYMotorLQ7g nvFHCg+vtrwmAXIq2/U7jnJEnIFy8T0BM0qYL0tPUFh1akd6Lbeqt6P5mA9Or/lmKWQ8JaihgPW SrOdQDUvnjwQEzD69kZv2v3g6PypoWgOeBsk6uedQhfJ6ag4KQtfqL+Lsx5TJIwB7+gNMJT35ZU wycCzu0GQCpHRGxO6dG7MErD7eIUa3oid7ELvwqbThp2RGHn/zwuiLKvJZBdRxuIUhZzkC1QmMO vkVufR3EriXeJsmqZxRWhMrYwp9O8g== X-Proofpoint-ORIG-GUID: 9e99JNflG0ECUfWdOg94Dk_XFX4SOsEO X-Proofpoint-GUID: 9e99JNflG0ECUfWdOg94Dk_XFX4SOsEO X-Authority-Analysis: v=2.4 cv=edgwvrEH c=1 sm=1 tr=0 ts=69428122 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KssOz9qI_-APc-HC6jIA:9 a=A62DG5RJPRbGacMD:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170080 On 12/6/2025 2:48 AM, Dmitry Baryshkov wrote: > On Wed, Dec 03, 2025 at 10:48:14AM +0530, Vikash Garodia wrote: >> >> On 12/3/2025 2:54 AM, Bjorn Andersson wrote: >>> On Tue, Dec 02, 2025 at 03:43:17PM +0530, Vikash Garodia wrote: >>>> >>>> On 12/2/2025 2:06 PM, Mukesh Ojha wrote: >>>>> On Thu, Nov 27, 2025 at 10:25:23AM +0000, Bryan O'Donoghue wrote: >>>>>> On 21/11/2025 11:37, Mukesh Ojha wrote: >>>>>>>> Sorry. >>>>>>>> >>>>>>>> Did we actually come up with a cogent reason to omit the video firmware >>>>>>>> loading here ? >>>>>>>> >>>>>>>> AFAIU it is required for Lemans and Glymur - leaving it out is blocking >>>>>>>> getting video stuff done and storing up trouble. >>>>>>>> >>>>>>>> What exactly is the blockage - is it something you want help with ? >>>>>>> I replied to you here[1] and given my reason..till something concluded on >>>>>>> "multi-cell IOMMU[2]", I can not add video and block what is working >>>>>>> already. >>>>>>> >>>>>>> [1] >>>>>>> https://lore.kernel.org/lkml/20251105081421.f6j7ks5bd4dfgr67@hu-mojha- >>>>>>> hyd.qualcomm.com/ >>>>>> >>>>>> Why though ? >>>>>> >>>>>> You are mixing together the issue of multiple SIDs and the original loading >>>>>> of firmware which could easily reuse the venus method of >>>>>> >>>>>> &iris { >>>>>> video-firmware { >>>>>> iommus = <&apss_smmu hex>; >>>>>> }; >>>>>> }; >>>>> >>>>> I completely understand what you are saying, and it would be very easy >>>>> for me to do that if it gets accepted. However, I doubt that the people >>>>> who raised this concern would agree with the approach. >>>>> >>>>> I’m not sure if the video team would like to pursue pixel/non-pixel/firmware context >>>>> banks separately. I’ll leave this to @Vikas to answer. >>>> >>>> Not exactly as a separate sub-node, but i do like the idea of introducing a >>>> simple iommu property, something like this, which Stephan proposed earlier >>>> in the discussion [1] >>>> >>>> firmware-iommus = <&apps_smmu ...>; >>>> >>>> I understand that we are doing the iommu-map thing, but a property >>>> exclusively for firmware like above look much simpler to me. >>>> >>> >>> "We know we need to find a generic solution to this very problem, but >>> while we work on that let's add this quick hack to the ABI"? >> >> I would not call that as hack, rather a simpler solution instead of packing >> everything into the generic iommu-map. >> >> "firmware-iommus" is much more readable to interpret something running in >> el2 mode, than digging into function ids inside iommu-map and then matching >> it up with specific SIDs to confirm. > > If you want it formally, NAK from my side for firmware-iommus. Either > reuse an existing approach (at least it makese sense from the historical > point of view) or introduce a generic approach, which is iommu-maps. The > proposed firmware-iommus is definitely a hack around the IOMMU > properties. > > But it's really off-topic here. Infact i see a concern with the iommu-map approach for firmware SIDs. Let say the hardware generates 10 SIDs, including firmware. So video binding should describe those 10 SIDs and the DTS should have all those 10 SIDs as well, including firmware SID. Given above, video driver cannot distinguish if the SOC is running in EL2 (KVM) mode or Gunyah mode. Could you please suggest if we can make it work with iommu-map approach Regards, Vikash