mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Ian King <colin.king@canonical.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>,
	Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base
Date: Thu, 9 May 2019 15:29:42 +0100	[thread overview]
Message-ID: <55f8efee-a02c-1574-42fa-35e1d3df14f7@canonical.com> (raw)
In-Reply-To: <20190509141313.GA17053@zn.tnic>

On 09/05/2019 15:13, Borislav Petkov wrote:
> On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The variable tad_base is being set to a value that is never read
>> and is being over-written on the next iteration of a for-loop.
>> This assignment is therefore redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
> 
> What's that tag's function supposed to be?

These are the Coverity static analysis warning/error message
classifications.  Tagging them should be useful for several reasons:

1. We can classify the types of issues being fixed
2. We can see how many issues are being found/fixed with the use of
static analysis tools like Coverity
3. It provides some context on how these bugs were being found.

I hope that helps.

> 
> I see a lot of those in commit messages but it is nowhere documented in
> the tree.
> 
> $ git grep -i coverity
> 
> doesn't give anything relevant.
> 
> Hmm?
> 


  reply	other threads:[~2019-05-09 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 22:42 Colin King
2019-05-08 22:48 ` Luck, Tony
2019-05-09 14:13 ` Borislav Petkov
2019-05-09 14:29   ` Colin Ian King [this message]
2019-05-09 14:41     ` Borislav Petkov
2019-05-09 14:46       ` Dan Carpenter
2019-05-09 14:54         ` Borislav Petkov
2019-05-09 14:55       ` Colin Ian King
2019-05-09 15:01         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55f8efee-a02c-1574-42fa-35e1d3df14f7@canonical.com \
    --to=colin.king@canonical.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®