From: "Vincent Dagonneau" <v@vda.io>
To: "Willy Tarreau" <w@1wt.eu>, "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests
Date: Mon, 27 Feb 2023 21:07:57 -0500 [thread overview]
Message-ID: <55fa16a3-068f-4b53-b1b3-831b7f013830@app.fastmail.com> (raw)
In-Reply-To: <Y/bV5D8gmG0B7DpN@1wt.eu>
On Wed, Feb 22, 2023, at 21:56, Willy Tarreau wrote:
> On Thu, Feb 23, 2023 at 01:53:06AM +0000, Thomas Weißschuh wrote:
>> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> > Hi,
>> >
>> > This is version 6 of the patch to add stdint.h to nolibc. Previous
>> > versions of this patch are available here:
>> >
>> > * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
>> > * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
>> > * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> > * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> > * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>> >
>> > This version integrates the feedback from Thomas, removing the limits
>> > for ssize_t (not required by the standard) as well as multiple cosmetic
>> > issues.
>>
>> Thanks, for the whole series:
>>
>> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
>
> Thanks to you both! I'll take care of all this this week-end.
>
>> Note:
>>
>> When sending new revisions it makes sense to add reviewers and
>> commenters of the previous versions on Cc.
>>
>> It makes it easier for them and gives you a faster review or
>> Reviewed-by.
>
> Agreed. Overall I find that for his first patchset Vincent has
> done a great job ;-)
>
Thank you for your guidance on this patchset!
> Cheers,
> Willy
next prev parent reply other threads:[~2023-02-28 2:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:00 Vincent Dagonneau
2023-02-23 1:00 ` [PATCH v6 1/4] tools/nolibc: add stdint.h Vincent Dagonneau
2023-02-23 1:00 ` [PATCH v6 2/4] tools/nolibc: add integer types and integer limit macros Vincent Dagonneau
2023-02-23 1:00 ` [PATCH v6 3/4] tools/nolibc: enlarge column width of tests Vincent Dagonneau
2023-02-23 1:00 ` [PATCH v6 4/4] tools/nolibc: add tests for the integer limits in stdint.h Vincent Dagonneau
2023-02-25 9:37 ` Willy Tarreau
2023-02-28 2:10 ` Vincent Dagonneau
2023-02-23 1:53 ` [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests Thomas Weißschuh
2023-02-23 2:56 ` Willy Tarreau
2023-02-28 2:07 ` Vincent Dagonneau [this message]
2023-02-28 2:08 ` Vincent Dagonneau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fa16a3-068f-4b53-b1b3-831b7f013830@app.fastmail.com \
--to=v@vda.io \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®