From: zhenwei pi <pizhenwei@bytedance.com>
To: mst@redhat.com
Cc: jasowang@redhat.com, arei.gonglei@huawei.com,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-crypto@vger.kernel.org, helei.sig11@bytedance.com,
davem@davemloft.net
Subject: PING: [PATCH v6 0/5] virtio-crypto: Improve performance
Date: Wed, 11 May 2022 11:27:52 +0800 [thread overview]
Message-ID: <55fc700a-9cdb-a4ed-c155-5b03a328eb6c@bytedance.com> (raw)
In-Reply-To: <20220506131627.180784-1-pizhenwei@bytedance.com>
Hi, Michael
I would appreciate it if you could review this series!
On 5/6/22 21:16, zhenwei pi wrote:
> v5 -> v6:
> - Minor fix for crypto_engine_alloc_init_and_set().
> - All the patches have been reviewed by Gonglei, add this in patch.
> Thanks to Gonglei.
>
> v4 -> v5:
> - Fix potentially dereferencing uninitialized variables in
> 'virtio-crypto: use private buffer for control request'.
> Thanks to Dan Carpenter!
>
> v3 -> v4:
> - Don't create new file virtio_common.c, the new functions are added
> into virtio_crypto_core.c
> - Split the first patch into two parts:
> 1, change code style,
> 2, use private buffer instead of shared buffer
> - Remove relevant change.
> - Other minor changes.
>
> v2 -> v3:
> - Jason suggested that spliting the first patch into two part:
> 1, using private buffer
> 2, remove the busy polling
> Rework as Jason's suggestion, this makes the smaller change in
> each one and clear.
>
> v1 -> v2:
> - Use kfree instead of kfree_sensitive for insensitive buffer.
> - Several coding style fix.
> - Use memory from current node, instead of memory close to device
> - Add more message in commit, also explain why removing per-device
> request buffer.
> - Add necessary comment in code to explain why using kzalloc to
> allocate struct virtio_crypto_ctrl_request.
>
> v1:
> The main point of this series is to improve the performance for
> virtio crypto:
> - Use wait mechanism instead of busy polling for ctrl queue, this
> reduces CPU and lock racing, it's possiable to create/destroy session
> parallelly, QPS increases from ~40K/s to ~200K/s.
> - Enable retry on crypto engine to improve performance for data queue,
> this allows the larger depth instead of 1.
> - Fix dst data length in akcipher service.
> - Other style fix.
>
> lei he (2):
> virtio-crypto: adjust dst_len at ops callback
> virtio-crypto: enable retry for virtio-crypto-dev
>
> zhenwei pi (3):
> virtio-crypto: change code style
> virtio-crypto: use private buffer for control request
> virtio-crypto: wait ctrl queue instead of busy polling
>
> .../virtio/virtio_crypto_akcipher_algs.c | 95 ++++++------
> drivers/crypto/virtio/virtio_crypto_common.h | 21 ++-
> drivers/crypto/virtio/virtio_crypto_core.c | 55 ++++++-
> .../virtio/virtio_crypto_skcipher_algs.c | 140 ++++++++----------
> 4 files changed, 182 insertions(+), 129 deletions(-)
>
--
zhenwei pi
prev parent reply other threads:[~2022-05-11 3:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 13:16 zhenwei pi
2022-05-06 13:16 ` [PATCH v6 1/5] virtio-crypto: change code style zhenwei pi
2022-05-06 13:16 ` [PATCH v6 2/5] virtio-crypto: use private buffer for control request zhenwei pi
2022-05-06 13:16 ` [PATCH v6 3/5] virtio-crypto: wait ctrl queue instead of busy polling zhenwei pi
2022-05-06 13:16 ` [PATCH v6 4/5] virtio-crypto: adjust dst_len at ops callback zhenwei pi
2022-05-06 13:16 ` [PATCH v6 5/5] virtio-crypto: enable retry for virtio-crypto-dev zhenwei pi
2022-05-11 3:27 ` zhenwei pi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fc700a-9cdb-a4ed-c155-5b03a328eb6c@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=arei.gonglei@huawei.com \
--cc=davem@davemloft.net \
--cc=helei.sig11@bytedance.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®