mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: chao@kernel.org, Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid setting SBI_NEED_FSCK on transient resize failure
Date: Fri, 21 Aug 2026 07:52:06 +0800	[thread overview]
Message-ID: <55fed9d7-cec1-42f8-9b79-19a95bacb340@kernel.org> (raw)
In-Reply-To: <20260820164340.2802152-1-daeho43@gmail.com>

On 8/21/26 00:43, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
> 
> When free_segment_range() fails in f2fs_resize_fs(), no on-disk
> superblock or filesystem metadata has been modified yet, and
> free_segment_range() safely restores all in-memory counters before
> returning.
> 
> However, the current error recovery path unconditionally sets the
> SBI_NEED_FSCK flag and prints a scary error message on any error,
> forcing an unnecessary and time-consuming fsck.f2fs repair on the
> subsequent mount/reboot.
> 
> Fix this by separating the error recovery path with a dedicated
> recover_user_blocks label to bypass setting SBI_NEED_FSCK on
> free_segment_range() failures.
> 
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

      reply	other threads:[~2026-08-20 23:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 16:43 Daeho Jeong
2026-08-20 23:52 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55fed9d7-cec1-42f8-9b79-19a95bacb340@kernel.org \
    --to=chao@kernel.org \
    --cc=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®