From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759561AbbIVTCz (ORCPT ); Tue, 22 Sep 2015 15:02:55 -0400 Received: from mail-bl2on0070.outbound.protection.outlook.com ([65.55.169.70]:21344 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759528AbbIVTCf (ORCPT ); Tue, 22 Sep 2015 15:02:35 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5601A5C2.4030206@caviumnetworks.com> Date: Tue, 22 Sep 2015 12:02:26 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon CC: David Daney , "linux-kernel@vger.kernel.org" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Marc Zyngier , David Daney Subject: Re: [PATCH 3/3] PCI: generic: Add support for Cavium ThunderX PCIe root complexes. References: <1442529694-1792-1-git-send-email-ddaney.cavm@gmail.com> <1442529694-1792-4-git-send-email-ddaney.cavm@gmail.com> <20150922185230.GR7356@arm.com> In-Reply-To: <20150922185230.GR7356@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0026.namprd07.prod.outlook.com (10.141.52.154) To BN3PR0701MB1718.namprd07.prod.outlook.com (25.163.39.17) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1718;2:r/b2pryLqz1i3K8Dl9wMF3C/qS9sLE4uRcnQXXgkqjRtViVrv1JJhYYaUbnf4PiVAltsLAWO6ib9NQx5RCthaWUN0VyBpK5cFtTV0clzV4kOLvEbqrgZgnaqAAZF5oAX+TpLeXZILye8wjEdxw6R5kCuF8uukNYF98fvC3Rk0kE=;3:KXc8GH0hDlAmDpbRcaADY6FwGK0C0Kk2uedDz+da/6woCLv1ZuJti3AtLNOkc7b5JdmAy1HFEeVrqY3mFPybvdZFLMcWfhSGquiJXK8V8ETgpvLH3+INfjyW5E5QF0ihHZ5nJOIMAWXWVsI9+SgiQg==;25:aHHPcop6JxkJGxS6fZpoxYCqiFoZkHI2PvbQfJiqRJPFabxGh5wEVCPpj2YwZIg15+fvPHqhoj2WI5PnUcrALbNPVtJP4jWxuFzcuDI/3NtKouS3cPVkFHK0kxVnKqoaScXkuN6t2gdBrhJGyD7vGm0afMol7sbUS7nwq0mPnenZI/G9jErBd2ZyZMZiK5ZREV5UXo6HuidA0Kb6YX/pMSMkkJbm/iTFzpt0TF120t10VzPKI7caE16SPOjbCv6BS/UUJPzEzt5NpcVo9M/U5g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1718;20:tGpD3MBT6HY9BNKVuebpK+zHTC7ksVyPR0OzJpyxdCRF1aWjzYfisBajRzZLzRiq5DoatPMf4eGKe9UtY1QiCEDn2pYFAX1ozSJHDn9O8qADZ4QM9EI6TmQW84wPam+kJZ4VSw5dQ5ebdYpo6UFTX1n0yuidDTHSenEnhxQCjly/EwqqZ903ITwvAaOnf2VgnQyYtN/USYo9bX83v4Wooq6+K/rnEOIZTTzcKbgsXAj44k8Krn1jvD/AmXORfX+1iieKiB3QoTRNqfbPgVzlWcKj89kQ13Q8YWOyVthi9nkZcbONFQryKhMqMn/2zhGHELzjCp5DvP1RTTXyBhB0ooR0VaZim8VJWOf+KvGZOxHYYVi0CHWAEqBfLdfbn3BqlVrLgDY9cMMLctvsnLsrclau8siTByW9fdLo2niFnuBPwtCPZxLuZPDLXCDzr73tdQYNoMve6LXgABCZGEE0QuDut2YHNSJUY94mKUWuKA95I+mrP6slH1ODDG0l6k35VeRDDKTN/Z8XEp2CsaHBEuwUEDC/xDNWyaWppmDW6jKZWHleNEB2vWD4yqnijMyipFKncAj2/zmxrzh/TlAOa6ZBOo+1h3iSZtg1rNjAfA8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:BN3PR0701MB1718;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1718;4:AG9/OuQRi29u5Xc4kMYMAZxQI9ufKDyfvK8NVJzm9zfcVrB5Q3YICczYP6poiUM008zcU5YjJKu7pmAsiirItPgZH2DRGp7ZqYaf3RRKL1fPtzpC/ZeXSpXqFkkzyHa5D4vKCTLjvorip4FBOltA3w1JriqamSWXMv3xgqM4j7zAMOMvoB6Ws7mCj517iO6lt77GeFExUBb5cKT3rcUzLY+0E6tazyV58A/nNXrhZdrQByAU/q/uUnzJZrDNDit2TgAW9YZnROQZwGSfjeRVuLP3AwHGQEDNqChCr7H9AuuoXl9A8G2weqzaEbXRpNPEBus4GOActl4pdikNt4AMIYtNhRXXjB+5Yi6DyQs+beM= X-Forefront-PRVS: 0707248B64 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(164054003)(199003)(189002)(479174004)(92566002)(5001960100002)(77096005)(189998001)(110136002)(80316001)(19580405001)(50986999)(46102003)(4001350100001)(36756003)(5004730100002)(97736004)(81156007)(54356999)(5001860100001)(106356001)(19580395003)(62966003)(77156002)(50466002)(68736005)(5001830100001)(5007970100001)(40100003)(66066001)(4001540100001)(83506001)(105586002)(2950100001)(122386002)(42186005)(64706001)(76176999)(47776003)(53416004)(87266999)(101416001)(65956001)(33656002)(69596002)(23756003)(59896002)(65806001)(64126003)(87976001)(65816999)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1718;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN3PR0701MB1718;23:fuKxMLsM/TlPYrl1eaEqtywryzAw64NQWRggu?= =?iso-8859-1?Q?jNsJnK21uWixXBPCxHQROW+AatAOlHLlqv61pIRsH4olb3du881UA9Y7k/?= =?iso-8859-1?Q?o/8Jm89XEgbp4SGfbXGwoH1vHZkye0O2KAyZ4oE2Kidulu3m5AiFr/obiM?= =?iso-8859-1?Q?N+OM4CFeUqneYP4qzFYC/tBkFSLXCkRUzRxp4DvQSd+RaJGFUOvhme9h1m?= =?iso-8859-1?Q?5VbcXlazFkPKhLWev+jTkoB5OilkjGm66C3bgvEpB3xix8LHF2eNiZmb1W?= =?iso-8859-1?Q?T8paWZyNcdclp9eGz5VdHYBwty6WhIaw2UNhd2esWR7p84NJGlnF85CeCh?= =?iso-8859-1?Q?3rLMQbggC7rmr0ZTO8MfmmF/ApQQorNa5VT/RtDF5QXolASztWQSzs+Obt?= =?iso-8859-1?Q?pQm9IGMJnUymOzMs716EF8Z8N7cpcYCmD+xRitKaDDkG9grHj++XChhZA8?= =?iso-8859-1?Q?dmsWf3qZhGgNWPBK+dVkNm9y70frQ0+QKo86CwKxUnYrLLTouksSod/6kd?= =?iso-8859-1?Q?mUtnsZyzkLc0JdQ8iZL3VDtdMCJKeuxO6RVKm/Hijx/N46UwSNgMhISYVr?= =?iso-8859-1?Q?3fU9y06ls4j2XnZ3QoVSOIBB720wSXo8Qko7dC7yruNy/yqnWT/CAh9Gy+?= =?iso-8859-1?Q?+MPasUIntIxJh3rQQ57ex2uk2cYa/+GwHQ3F3/AkTFZAE5KsxxAR5lFIIw?= =?iso-8859-1?Q?dWIPeuBkkEpJmlhTF257FIeFFNxFgo5XVNlYmjix49hOQ/lnWmYkvovK4p?= =?iso-8859-1?Q?cNBGzgvEkWipMmOyxM/iw5LMY0X7GI4yYAL6rfwK5Y9WEnBwU3wG5+3J0Y?= =?iso-8859-1?Q?mtbPpIhDkp3600FoisY3qtCwvDS5s2Kc1h8sgqtGGt9vvTWBwvYsXUtrEF?= =?iso-8859-1?Q?zTkXVo9k/bVyu3WU1VJaAncx7eR2UBWKdQW02e0BBu8VXvc6AlM1vfxvi/?= =?iso-8859-1?Q?W2zzxDSzH+IRHVibcUO1tgo7ZsM4pVDw9cXz170AattqWLEr8I9sYiP7KJ?= =?iso-8859-1?Q?K45EolCKowfXrl4x4QaWWKDpxgJKO8Z7pHrqKwV//2H9TA1pbuJA6PDUct?= =?iso-8859-1?Q?OLWa9vaJjrQWWLsX/qPY/weB9XdWYwgKd9X++th/n+dZrbSAC1O0kyhXPi?= =?iso-8859-1?Q?XriTs0b8HigI6N/IhGUzJtcVjxb35pzw3afHBwoJvnnLxW2En1nHALXl7W?= =?iso-8859-1?Q?Mw+d5g12vxd/leFNoeDvWFE7oxuNqmAHUxbeIDjuqG5LeMSjAIk6AsU80d?= =?iso-8859-1?Q?qyobUYLZQ6VkT4/FHPp79euHaCwCV2M16tY5LMvrQKwuqkMl8z7IGIYK4j?= =?iso-8859-1?Q?yEvNvQaFUIwQHEF2ndSTEy6eW/JagiVI9hwag+8DCi979/ujWTiW8v+zJ1?= =?iso-8859-1?Q?1jRDe+Sq6Q6kERybnXu2cluPpA4mupbO8VwC++qs1fZRBeiqwrPUpKD8Q3?= =?iso-8859-1?Q?ByOO9zr5YLRF6w6vlKoQ+MJjP1+2zlNlMLfOniKHdItjfEEfaLd2sy/Txd?= =?iso-8859-1?Q?YE/DdAHrMHs7DKXBuK9imA=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1718;5:48UArYnmjWUH0gpQ/i3ik7NqN81Ai/0WuVLA+NVvLEft5ZjiB+PWdrrgb1PG9wXpZ6WO/HY+TbnbplOLHukQoUo/1cexwCfUxqk5OWQzxO8+dXLXQq9QJUhRIvhl3fnEuIOQhttpNiM/KRHTPVFX8g==;24:SqN4K61vQbg7qtxzYGqg5jzAcSvHEHxIEH54pehiz3ACH8NLqOpaBExlTGQA3FPdFocSkOiFqxk0LQdygtq8rkQ6a3bPYmbBnhhHiOWbR4Y=;20:8GjJSDAguLHnF103B/4lROEl/WarzZ/uAem7NCrGvQwvawIhW148/TDdjWERJ4vQwxskgGIF5Wrak+o3NKB/PA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2015 19:02:29.8187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1718 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2015 11:52 AM, Will Deacon wrote: > On Thu, Sep 17, 2015 at 11:41:34PM +0100, David Daney wrote: >> From: David Daney >> >> The config space for external PCIe root complexes on some Cavium >> ThunderX SoCs is very similar to CAM and ECAM, but differs in the >> shift values that have to be applied to the bus and devfn numbers to >> compose that address window offset. These root complexes also have >> the interesting property that there is no root bridge, so the standard >> manner of limiting scanning to only the first device doesn't work. We >> can use the standard pci-host-generic driver if we make a minor >> addition to handle these differences, so we... >> >> Add a mapping function for ThunderX PCIe root complexes with a bus >> shift of 24 and devfn shift of 16. Ignore accesses for devices other >> than the first device on the primary bus. >> >> Document the whole thing in devicetree/bindings/pci/host-generic-pci.txt >> >> Signed-off-by: David Daney >> --- >> .../devicetree/bindings/pci/host-generic-pci.txt | 8 +++--- >> drivers/pci/host/pci-host-generic.c | 29 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+), 3 deletions(-) > > Thanks, this looks better now: > > Acked-by: Will Deacon > Thanks Will. Because patches 1/3 and 2/3 will be reworked, I will re-send this as a stand-alone patch. David Daney > Will >