From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771AbbIXHkO (ORCPT ); Thu, 24 Sep 2015 03:40:14 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:54955 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932635AbbIXHkM (ORCPT ); Thu, 24 Sep 2015 03:40:12 -0400 Message-ID: <5603A8C7.9050104@schinagl.nl> Date: Thu, 24 Sep 2015 09:39:51 +0200 From: Olliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Alexandre Courbot , Olliver Schinagl CC: Linus Walleij , Mika Westerberg , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH 1/1] gpio: gpiolib: fix identation References: <1443078892-4417-1-git-send-email-oliver+list@schinagl.nl> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Appologies! I should not do this early in the morning. It is indeed a copy/paste fail (and not noticing the missing minus) from the section above i was working on. I'm sorry for the noise! Olliver On 24-09-15 09:17, Alexandre Courbot wrote: > On Thu, Sep 24, 2015 at 4:14 PM, Olliver Schinagl > wrote: >> From: Olliver Schinagl >> >> Just a very small cosmetical indentation fix, no code changes > You are adding two lines and not removing any, so it is not just a > cosmetic fix and actually adds code. > >> Signed-off-by: Olliver Schinagl >> --- >> drivers/gpio/gpiolib.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c >> index 980c1f8..5ef9ac2 100644 >> --- a/drivers/gpio/gpiolib.c >> +++ b/drivers/gpio/gpiolib.c >> @@ -1746,6 +1746,8 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id, >> if (con_id && strcmp(con_id, "gpios")) { >> snprintf(propname, sizeof(propname), "%s-%s", >> con_id, gpio_suffixes[i]); >> + if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER)) >> + break; >> } else { >> snprintf(propname, sizeof(propname), "%s", >> gpio_suffixes[i]); >> -- >> 2.5.1 >>