Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]


On 17/09/15 17:21, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..ecbc9e5 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, dmm_of_match);
>  #endif
>  
>  struct platform_driver omap_dmm_driver = {

I think this one is not needed.

Tiler cannot be compiled as a module. Or, to be more exact, the tiler
driver is included in the omapdrm module, along with the main omapdrm
driver, which can be a module.

The autoloading should happen via omapdrm, and when that happens, tiler
driver comes along.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]