From: Krzysztof Opasiak <k.opasiak@samsung.com>
To: balbi@ti.com, Robert Baldyga <r.baldyga@samsung.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, andrzej.p@samsung.com,
b.zolnierkie@samsung.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling
Date: Thu, 24 Sep 2015 19:35:58 +0200 [thread overview]
Message-ID: <5604347E.1090107@samsung.com> (raw)
In-Reply-To: <20150924164913.GE14151@saruman.tx.rr.com>
On 09/24/2015 06:49 PM, Felipe Balbi wrote:
> On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote:
>> Move function parameters to struct f_sourcesink to make them per instance
>> instead of having them as global variables. Since we can have multiple
>> instances of USB function we also want to have separate set of parameters
>> for each instance.
>>
>> Cc: <stable@vger.kernel.org> # 3.10+
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>
> why do you think this is stable material ? Looks like it's not
> fixing anything to me; just implementing a brand new requirement.
>
Please see my answer in loopback patch[1]. It's totally the same case.
Both those functions have the same bug.
Footnotes:
1 - http://marc.info/?l=linux-usb&m=144311466118170&w=2
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2015-09-24 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 15:23 Robert Baldyga
2015-09-24 16:49 ` Felipe Balbi
2015-09-24 17:35 ` Krzysztof Opasiak [this message]
2015-10-14 8:38 ` Robert Baldyga
2015-10-14 13:38 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5604347E.1090107@samsung.com \
--to=k.opasiak@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome