From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Tejun Heo <tj@kernel.org>
Cc: Ming Lei <tom.leiming@gmail.com>, Jens Axboe <axboe@fb.com>,
"Christoph Hellwig" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH 3/3] blk-mq: Fix the queue freezing mechanism
Date: Thu, 24 Sep 2015 15:54:18 -0700 [thread overview]
Message-ID: <56047F1A.1060804@sandisk.com> (raw)
In-Reply-To: <20150924181430.GD25415@mtj.duckdns.org>
On 09/24/2015 11:14 AM, Tejun Heo wrote:
> On Thu, Sep 24, 2015 at 11:09:33AM -0700, Bart Van Assche wrote:
>> On 09/24/2015 10:49 AM, Tejun Heo wrote:
>>> Again, that doesn't happen.
>>
>> In case anyone would be interested, the backtraces for the lockup I had
>> observed are as follows:
>
> If this is happening and it's not caused by a hung in-flight request,
> it's either percpu_ref being buggy or the forementioned kill/reinit
> race screwing it up. percpu_ref_kill() is expected to disable
> tryget_live() in a finite amount of time regardless of concurrent
> tryget tries.
Hello Tejun,
Sorry that I had not yet made this clear but I agreed with the analysis
in your two most recent e-mails. I think I have found the cause of the
loop: for one or another reason the scsi_dh_alua driver was not loaded
automatically. I think that caused the SCSI core to return a retryable
error code for reads and writes sent over paths in the SCSI ALUA state
"standby" instead of a non-retryable error code and that that caused the
dm-mpath driver to enter an infinite loop. Loading the scsi_dh_alua
driver resolved the infinite loop. Anyway, thank you for the feedback.
Bart.
next prev parent reply other threads:[~2015-09-24 22:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 22:11 [PATCH 0/3] Block layer patches for kernel v4.4 Bart Van Assche
2015-09-23 22:12 ` [PATCH 1/3] blk-cgroup: Declare local symbols static Bart Van Assche
2015-09-25 15:35 ` Tejun Heo
2015-09-23 22:12 ` [PATCH 2/3] bsg: Add sparse annotations to bsg_request_fn() Bart Van Assche
2015-09-23 22:14 ` [PATCH 3/3] blk-mq: Fix the queue freezing mechanism Bart Van Assche
2015-09-24 3:22 ` Ming Lei
2015-09-24 16:43 ` Bart Van Assche
2015-09-24 16:53 ` Tejun Heo
2015-09-24 17:35 ` Bart Van Assche
2015-09-24 17:49 ` Tejun Heo
2015-09-24 18:09 ` Bart Van Assche
2015-09-24 18:14 ` Tejun Heo
2015-09-24 22:54 ` Bart Van Assche [this message]
2015-09-24 22:56 ` Tejun Heo
2015-09-24 19:04 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56047F1A.1060804@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome