From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266AbbIYXuT (ORCPT ); Fri, 25 Sep 2015 19:50:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:59877 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137AbbIYXuR (ORCPT ); Fri, 25 Sep 2015 19:50:17 -0400 Subject: Re: [PATCH v3 1/4] scsi: remove old-style type names from sg.h To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1443173264-4105-1-git-send-email-pbonzini@redhat.com> <1443173264-4105-2-git-send-email-pbonzini@redhat.com> Cc: bart.vanassche@sandisk.com, James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org From: Hannes Reinecke Message-ID: <5605DDB2.6070406@suse.de> Date: Sat, 26 Sep 2015 01:50:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443173264-4105-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/2015 11:27 AM, Paolo Bonzini wrote: > These will not be exported by the new linux/sg.h header, and scsi/sg.h will > not have any user API after linux/sg.h is created. Since they have no > user in the kernel, they can be zapped. > > Cc: James Bottomley > Cc: Christoph Hellwig > Cc: linux-scsi@vger.kernel.org > Reviewed-by: Bart Van Assche > Signed-off-by: Paolo Bonzini > --- > include/scsi/sg.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/scsi/sg.h b/include/scsi/sg.h > index 3afec7032448..370c78c37926 100644 > --- a/include/scsi/sg.h > +++ b/include/scsi/sg.h > @@ -207,12 +207,6 @@ typedef struct sg_req_info { /* used by SG_GET_REQUEST_TABLE ioctl() */ > > #define SG_BIG_BUFF SG_DEF_RESERVED_SIZE /* for backward compatibility */ > > -/* Alternate style type names, "..._t" variants preferred */ > -typedef struct sg_io_hdr Sg_io_hdr; > -typedef struct sg_io_vec Sg_io_vec; > -typedef struct sg_scsi_id Sg_scsi_id; > -typedef struct sg_req_info Sg_req_info; > - > > /* vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv */ > /* The older SG interface based on the 'sg_header' structure follows. */ > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)