From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755564AbbIYXzz (ORCPT ); Fri, 25 Sep 2015 19:55:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:60084 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137AbbIYXzy (ORCPT ); Fri, 25 Sep 2015 19:55:54 -0400 Subject: Re: [PATCH v3 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1443173264-4105-1-git-send-email-pbonzini@redhat.com> <1443173264-4105-5-git-send-email-pbonzini@redhat.com> Cc: bart.vanassche@sandisk.com, James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org From: Hannes Reinecke Message-ID: <5605DF03.5080204@suse.de> Date: Sat, 26 Sep 2015 01:55:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443173264-4105-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/2015 11:27 AM, Paolo Bonzini wrote: > Provide a UAPI version of the header in the kernel, making it easier > for interested projects to use an up-to-date version of the header. > > The new headers are placed under uapi/linux/ so as not to conflict > with the glibc-provided headers in /usr/include/scsi. > > /dev/sgN default values are implementation aspects, and are moved to > drivers/scsi/sg.c instead (together with e.g. SG_ALLOW_DIO_DEF). > However, SG_SCATTER_SZ is used by Wine so it is kept in linux/sg.h > SG_MAX_QUEUE could also be useful. > > struct scsi_ioctl_command and struct scsi_idlun used to be under > "#ifdef __KERNEL__", but they are actually useful for userspace as > well. Add them to the new header. > > Cc: James Bottomley > Cc: Christoph Hellwig > Cc: linux-scsi@vger.kernel.org > Cc: Bart Van Assche > Signed-off-by: Paolo Bonzini > --- [ .. ] Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)