From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757294AbbI1MFW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 08:05:22 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:37429 "EHLO
	mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755966AbbI1MFU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 08:05:20 -0400
Subject: Re: [PATCH] KVM: nVMX: expose VPID capability to L1
To: Wanpeng Li <wanpeng.li@hotmail.com>
References: <BLU437-SMTP361E29924E16FD4721E9F080430@phx.gbl>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Bandan Das <bsd@redhat.com>,
        Wincy Van <fanwenyi0529@gmail.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56092CFE.6070801@redhat.com>
Date: Mon, 28 Sep 2015 14:05:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <BLU437-SMTP361E29924E16FD4721E9F080430@phx.gbl>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 24/09/2015 08:51, Wanpeng Li wrote:
>  		/*
>  		 * For nested guests, we don't do anything specific
>  		 * for single context invalidation. Hence, only advertise
>  		 * support for global context invalidation.
>  		 */
> -		vmx->nested.nested_vmx_ept_caps |= VMX_EPT_EXTENT_GLOBAL_BIT;
> +		vmx->nested.nested_vmx_ept_vpid_caps |= VMX_EPT_EXTENT_GLOBAL_BIT;
> +		vmx->nested.nested_vmx_ept_vpid_caps |= (unsigned long)vmx_capability.vpid << 32;

Hi Wanpeng, the comment above is about invept, but the same applies
applies to invvpid.  We can set only VMX_VPID_EXTENT_GLOBAL_CONTEXT_BIT.

Paolo