From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712AbbI1Vic (ORCPT ); Mon, 28 Sep 2015 17:38:32 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:47607 "EHLO e18.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbbI1Via (ORCPT ); Mon, 28 Sep 2015 17:38:30 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: tyreld@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only To: Laurent Vivier , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" References: <1441876994-16821-1-git-send-email-lvivier@redhat.com> Cc: dgibson@redhat.com, thuth@redhat.com, pbonzini@redhat.com From: Tyrel Datwyler Message-ID: <5609B34F.6040507@linux.vnet.ibm.com> Date: Mon, 28 Sep 2015 14:38:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441876994-16821-1-git-send-email-lvivier@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15092821-0045-0000-0000-0000019F97D9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2015 02:23 AM, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier Acked-by: Tyrel Datwyler > --- > I resend this patch as James was not cc'ed. > > drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c > index 6a41c36..3e76490 100644 > --- a/drivers/scsi/ibmvscsi/ibmvscsi.c > +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c > @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher"); > MODULE_LICENSE("GPL"); > MODULE_VERSION(IBMVSCSI_VERSION); > > -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR); > +module_param_named(max_id, max_id, int, S_IRUGO); > MODULE_PARM_DESC(max_id, "Largest ID value for each channel"); > -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR); > +module_param_named(max_channel, max_channel, int, S_IRUGO); > MODULE_PARM_DESC(max_channel, "Largest channel value"); > module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds"); >