From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933371AbbI3SdR (ORCPT ); Wed, 30 Sep 2015 14:33:17 -0400 Received: from terminus.zytor.com ([198.137.202.10]:35587 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932807AbbI3SdK (ORCPT ); Wed, 30 Sep 2015 14:33:10 -0400 Subject: Re: [PATCH v2 1/2] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops To: Linus Torvalds , Ingo Molnar References: <130a3b7ef4788baae3a6fe71293ab17442bc9a0a.1442793572.git.luto@kernel.org> <20150921084642.GA30984@gmail.com> Cc: Andy Lutomirski , Thomas Gleixner , Paolo Bonzini , xen-devel , Arjan van de Ven , Andrew Morton , KVM list , the arch/x86 maintainers , Linux Kernel Mailing List , Peter Zijlstra From: "H. Peter Anvin" Message-ID: <560C2AA0.5040708@zytor.com> Date: Wed, 30 Sep 2015 11:32:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2015 09:36 AM, Linus Torvalds wrote: > > How many msr reads are so critical that the function call > overhead would matter? Get rid of the inline version of the _safe() > thing too, and put that thing there too. > Probably only the ones that may go in the context switch path. -hpa