From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754934AbbI3Xsc (ORCPT ); Wed, 30 Sep 2015 19:48:32 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:49169 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754381AbbI3Xs3 (ORCPT ); Wed, 30 Sep 2015 19:48:29 -0400 X-AuditID: cbfec7f5-f794b6d000001495-7b-560c74ca3c19 Subject: Re: [PATCH RESENDv2] mach:-s3c64xx:Output trace information with WARN_ON if calls for setting up gpio board configuration fail in s3c64xx_i2s_cfg_gpio To: Nicholas Krause , kgene@kernel.org References: <1443578870-14534-1-git-send-email-xerofoify@gmail.com> Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <560C74C7.7030409@samsung.com> Date: Thu, 01 Oct 2015 08:48:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1443578870-14534-1-git-send-email-xerofoify@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xa7qnSnjCDA490rZ4/cLQov/xa2aL TY+vsVpc3jWHzWLG+X1MFrcv81r8miLrwO7R0tzD5rFz1l12j02rOtk8Ni+p9+jbsorR4/Mm uQC2KC6blNSczLLUIn27BK6Mww9+shTcEKz4Nu8vWwPjab4uRk4OCQETiacrfrJB2GISF+6t B7K5OIQEljJKzF7SD+V8YZRomHOMGcQRFljMKDHzwhywFhEBa4n5928ygthCAs4SDw8+ZAIp YhZoZpTovniDHSTBJmAssXn5ErAGXgEtiY1fOsHiLAKqEtPXHgKLiwpESJw6+xaqRlDix+R7 LCA2p4CLxOoLR4DiHEBD9STuX9QCCTMLyEtsXvOWeQKjwCwkHbMQqmYhqVrAyLyKUTS1NLmg OCk910ivODG3uDQvXS85P3cTIyTQv+5gXHrM6hCjAAejEg+vRDpPmBBrYllxZe4hRgkOZiUR XqcUoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphakFsFkmTg4pRoYhSRS 51sermRv322j/WmykmNJRUHblGA3wV+VgW+uqM+Jjeq/zxgstXTP26fZXof3acgYe6kw6zz8 +eTfzZxJMkVMv/6IJOfsPX469KJwFI+436viKS9t1zsJ3okNaXaZ4r291Dbrmu/VHKvj3H4X F5oLZIne52bv3Hj/snT2Eu+mDW8Db/1RYinOSDTUYi4qTgQAhpthcXACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.09.2015 11:07, Nicholas Krause wrote: > This fixes the function s3c64xx_i2c_cfg_gpio to log output to the > kernel log buff with WARN_ON if any of the calls to either > s3c_gpio_cfgpin_range or s3c_gpio_cfgpin fail as we cannot exit > from s3c64xx_i2s_cfg_gpio if any of these calls fail due to > other intended function work being required to complete. This is better now. > Therefore > due to this output our failed calls by means of WARN_ON to the > kernel log buffer for failed configuration of gpio devices using > this driver file. I don't get this sentence. What do you want to say? > v2:Fix Patch Wording as it was clearly confusing and incorrect Changelog goes after --- separator. Last question - have you compiled it? I mean truly compiled like generated object file and linked objects into vmlinux? Best regards, Krzysztof > > Signed-off-by: Nicholas Krause > --- > arch/arm/mach-s3c64xx/dev-audio.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/dev-audio.c b/arch/arm/mach-s3c64xx/dev-audio.c > index ff780a8..5e7538b 100644 > --- a/arch/arm/mach-s3c64xx/dev-audio.c > +++ b/arch/arm/mach-s3c64xx/dev-audio.c > @@ -36,10 +36,10 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev) > base = S3C64XX_GPE(0); > break; > case 2: > - s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5)); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));) > return 0; > default: > printk(KERN_DEBUG "Invalid I2S Controller number: %d\n", > @@ -47,7 +47,7 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev) > return -EINVAL; > } > > - s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3)); > + WARN_ON(s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3))); > > return 0; > } >