From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756951AbbJAUCn (ORCPT ); Thu, 1 Oct 2015 16:02:43 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34841 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756735AbbJAUCl (ORCPT ); Thu, 1 Oct 2015 16:02:41 -0400 Message-ID: <560d9160.0c5b8c0a.eb9c4.169d@mx.google.com> Date: Thu, 01 Oct 2015 13:02:40 -0700 (PDT) From: Yasuaki Ishimatsu To: Xishi Qiu Cc: Andrew Morton , Mel Gorman , Tang Chen , , "Yasuaki Ishimatsu" , Zhang Yanfei , Linux MM , LKML Subject: Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() In-Reply-To: <560BAC76.6050002@huawei.com> References: <560BAC76.6050002@huawei.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 17:33:42 +0800 Xishi Qiu wrote: > If user set "movablecore=xx" to a large number, corepages will overflow, > this patch fix the problem. > > Signed-off-by: Xishi Qiu > --- Looks good to me. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 48aaf7b..af3c9bd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > */ > required_movablecore = > roundup(required_movablecore, MAX_ORDER_NR_PAGES); > + required_movablecore = min(totalpages, required_movablecore); > corepages = totalpages - required_movablecore; > > required_kernelcore = max(required_kernelcore, corepages); > -- > 2.0.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/