From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F47EB64DC for ; Sat, 8 Jul 2023 14:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbjGHOpl (ORCPT ); Sat, 8 Jul 2023 10:45:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbjGHOpj (ORCPT ); Sat, 8 Jul 2023 10:45:39 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DA651FC6 for ; Sat, 8 Jul 2023 07:45:32 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fb73ba3b5dso4686560e87.1 for ; Sat, 08 Jul 2023 07:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688827530; x=1691419530; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mCWNwoC2vevqpteh32b8WOBme258WwCa2vLzAXyfb24=; b=qPVyTW8LTPpMHYGn1WZY105+FBHqpbVs2HWQnONMcbmI/9eXTYb5f9FK9l81kaP8KF 1VTVaKs5IcKlOmVHovzoMQ/B0E/eY9pl16p6vkVyypCpWhxpi2MioVjQJyiwmGJ9RgFO ESo/ipRqQgyA8e9KBf46yFfBiFAytbtY0mQweSe4k9SOW3SI/1skjX6oOsUbAEDxOE1T yMll/jh4cst3r7lCz3eErSN2QBIa8tcG/40y7HZyGwpnJFhjsGYKH0Tr9TxMFKOPX/jA ssjaTbv5zpyOuXJB4vq7uEyDKWBPELUmff7egMwy6KCjg4IIEPN9b92MqZUxXSligVwK VOWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688827530; x=1691419530; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mCWNwoC2vevqpteh32b8WOBme258WwCa2vLzAXyfb24=; b=HUYQ7ppkeJ1C432KDNiDGYn0jW/mB53ZLlLAK+BD2IcHPPgLbOAHKn0y9VCaD/Do4P tke0NBrw12LbTzjS1noq1uipLyWdubrbgKlzGg2OPXRVGImMnP3VnPVTZZMdf8VcfWu4 6Vhv3NJkByDfrg8A5HBK0C36WpqVKjOmS9c3c8LLKt/dOeh1ecJeyxb0jVRDlp5NhEt9 C67QfJ19cOmCMaw/hy8s/l02LhrLKBRsqwKBjpLkR6B02lIQQYTarEkPfnlucR9jfWvg 3Hw9QX/A+/aRy3tQz/QcoWJ/NIRd43qVJVLiGUK32zb05JQthNNcx5HCIw4yiFpvINzN 5Mow== X-Gm-Message-State: ABy/qLbi8wSEGHc+1PXPOyJr38PZK1FCZ7WADSP1e2yAmsS1Wi9cBt7F 2sKAV3Vb3UYj6H/bbt7jN+B+Vw== X-Google-Smtp-Source: APBJJlHni0GxQlaTk5KXSBdPCs8J6B3hVlzahsgMn05+Zf518fqtVQ0deGO6RytJtJobYW8S7ku2zw== X-Received: by 2002:a19:911a:0:b0:4fb:89e3:5ac6 with SMTP id t26-20020a19911a000000b004fb89e35ac6mr5174424lfd.62.1688827530203; Sat, 08 Jul 2023 07:45:30 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id q7-20020a19a407000000b004fb9d32719fsm1045317lfc.36.2023.07.08.07.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jul 2023 07:45:29 -0700 (PDT) Message-ID: <560ddda0-338c-533b-35c5-58483ae0cea0@linaro.org> Date: Sat, 8 Jul 2023 16:45:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K_PU Content-Language: en-US To: Jonathan Cameron , Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Lars-Peter Clausen , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230627-topic-adc-v1-1-c61581abffa3@linaro.org> <20230708152931.146c6944@jic23-huawei> From: Konrad Dybcio In-Reply-To: <20230708152931.146c6944@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8.07.2023 16:29, Jonathan Cameron wrote: > On Tue, 27 Jun 2023 03:08:20 +0300 > Dmitry Baryshkov wrote: > >> On 27/06/2023 02:21, Konrad Dybcio wrote: >>> Even though it existed in bindings for the longest time, >>> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> drivers/iio/adc/qcom-spmi-adc5.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >> >> Reviewed-by: Dmitry Baryshkov >> > I was a little unsure on this one. So far I've applied it as a 'feature' > so it's in the normal iio togreg branch, but perhaps it should be a fix? I suppose it's a feature as it's never been used before Konrad > > For now applied to the togreg branch of iio.git but given I'll be rebasing > that on rc1, for now it's only visible as testing. 0-day can play with that > in the meantime and see if it can find any issues > > Jonathan > >