From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: linux-parisc@vger.kernel.org
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org
Subject: [PATCH 3/5] parisc: drop include of asm/pdc.h from asm/hardware.h
Date: Thu, 10 May 2012 23:03:26 +0200 [thread overview]
Message-ID: <5611809.8T3vflHrKr@donald.sf-tec.de> (raw)
In-Reply-To: <4430485.xEvkeJU8MB@donald.sf-tec.de>
It seems none of the symbols defined by pdc.h is needed, but it introduces an
include loop causing compile errors:
In file included from /home/buildbot/repos/linux/arch/parisc/include/asm/spinlock.h:4:0,
from /home/buildbot/repos/linux/arch/parisc/include/asm/atomic.h:20,
from /home/buildbot/repos/linux/include/linux/atomic.h:4,
from /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:56,
from /home/buildbot/repos/linux/include/linux/bitops.h:35,
from /home/buildbot/repos/linux/include/asm-generic/getorder.h:7,
from /home/buildbot/repos/linux/arch/parisc/include/asm/page.h:162,
from /home/buildbot/repos/linux/arch/parisc/include/asm/pdc.h:346,
from /home/buildbot/repos/linux/arch/parisc/include/asm/hardware.h:5,
from /home/buildbot/repos/linux/arch/parisc/kernel/hardware.c:30:
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:74:16: error: field ‘cpu_type’ has incomplete type
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:77:20: error: field ‘model’ has incomplete type
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h: In function ‘parisc_requires_coherency’:
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:349:36: error: ‘mako’ undeclared (first use in this function)
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:349:36: note: each undeclared identifier is reported only once for each function it appears in
/home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:350:30: error: ‘mako2’ undeclared (first use in this function)
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Acked-by: Grant Grundler <grantgrundler@gmail.com>
---
arch/parisc/include/asm/hardware.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/parisc/include/asm/hardware.h b/arch/parisc/include/asm/hardware.h
index 036e703..d1d864b 100644
--- a/arch/parisc/include/asm/hardware.h
+++ b/arch/parisc/include/asm/hardware.h
@@ -2,7 +2,6 @@
#define _PARISC_HARDWARE_H
#include <linux/mod_devicetable.h>
-#include <asm/pdc.h>
#define HWTYPE_ANY_ID PA_HWTYPE_ANY_ID
#define HVERSION_ANY_ID PA_HVERSION_ANY_ID
--
1.7.9.2
next prev parent reply other threads:[~2012-05-10 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 20:50 [PATCH 0/5] PA-RISC: fix compile Rolf Eike Beer
2012-05-10 20:57 ` [PATCH 1/5] parisc: add missing includes in asm/spinlock.h Rolf Eike Beer
2012-05-10 21:01 ` [PATCH 2/5] parisc: add missing forward declarations in asm/hardware.h Rolf Eike Beer
2012-05-10 21:03 ` Rolf Eike Beer [this message]
2012-05-10 21:07 ` [PATCH 4/5] parisc: add missing include of asm/page.h to asm/pgtable.h Rolf Eike Beer
2012-05-10 21:08 ` [PATCH 5/5] parisc: move definition of PAGE0 to asm/page.h Rolf Eike Beer
2012-05-10 22:23 ` [PATCH 0/5] PA-RISC: fix compile Linus Torvalds
2012-05-10 22:44 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5611809.8T3vflHrKr@donald.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®