From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96A63254A0 for ; Wed, 15 Jul 2026 06:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784098735; cv=none; b=a3IWJJCroLoc69bRMD7xthIah8P5NiqG/d5MdV8TU1FKGX97ie92alwrmwz6YcHsUjQwN5ViUIprFoD5LEqrthGGB2m5KeXLzRGtKcKFlsekll9WIHB/qaWoj2xaOhCIpra8kqze5SF2UjrqN04QJ3U8W6cWAepDL98hcP7TV8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784098735; c=relaxed/simple; bh=2F33bP0CzluWiHtV3rOJhAl9WdVxVvWgw0557LH7+2A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UwTGA6+Z3h2hfzr0ojIdhSj93zzTMo34HGqNuJqxcfRVJ1bRDklrghcoil6OiZFj1f+INpLY+nXw78RoH+uSXDw0ncjYycTPjTzLn5LZiBxiyV1Q+KiRIaGx9rJne0A0ezyJ2sDm8IDvPdi8+6wN0aizQ5p2evkhDHD1LjtiLYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zh2XcmcS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dabs0OpS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zh2XcmcS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dabs0OpS" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F3lhPX2622101 for ; Wed, 15 Jul 2026 06:58:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k5rLcyyrbG3p5cljmeoN2CF98kBOhnagbjStEAg0Lso=; b=Zh2XcmcSe/bVKFC4 evZ53wuZJ5ujyAm1LDk1V0py4eGQ1QtQ0+WmLgSXEcnVxywgI8isRvpYoVLNCZhu 36tgD26HQFRoASvUlmUHivsz8e7tFwi8xCOHbfneAfCVrWI0g1ZhtPh9dYIdd2za 4K+FTn3Pd+joJHdTyt48O2AoDt/CzD29NHvGzXQVQL6h68Kq6eIT5YG/chfssL12 M8oJUkC5tBhdNYDCJWBSw++1+DuETCuBEvQsXlfkHfsJjFuEE/4MJA4nd4RKnc6q j7NfbZ/HRRJ8KIsdDQycdvj7YubuLHD+SzkHLw1pSb6OtqIeNmg9MQzqIaoOYd/R G08Dyw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fe03vh117-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 06:58:52 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c894391f000so3956875a12.1 for ; Tue, 14 Jul 2026 23:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784098731; x=1784703531; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k5rLcyyrbG3p5cljmeoN2CF98kBOhnagbjStEAg0Lso=; b=dabs0OpSD9xZe9so97AfbU7G1+nPMOIFSh+4xim2vfhcZauFULq9AHP70RM4MstL1F nuwnwjkVDH9zRFgNwMIwq6I0Tp4v9Q0a2PU1vUSZpwJv3slESbHR4geoA1M2c9kjFBxy 2lDIL7l50xWvJXQq3F85OitBL0B4n4Oj5l7vrad82qz3K2IH4q2EC/494B1/dJUZ3ivl 3PShb59AMIJ2CvsafZpT8uQXNYjJRYSVtw9FC063sLCnZwMRCH5Ddb0PCjjcBpNbd6Q7 NVKd5gAZfc9y7z6T75ARndnsvKgXsN6Qd/Jjzbn7BAkp3lgmXOMhBYDCYRIjnLzh4Prq Z0VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784098731; x=1784703531; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k5rLcyyrbG3p5cljmeoN2CF98kBOhnagbjStEAg0Lso=; b=nepOGBEkUYVORFsQtJwrZ4EsmVlhOxuQVCyE2DlpKKhgw4i+OqDOccdscmDyNejPkz cz3GjINUroAdP3tsDpS3SEFNJr7RcPWsdRtKrdAHskxxeva8SfoHNGbs6yZy3v6fxHyP 85BRjuWOg93/Kehth+IEDEwlYzFVTYkSWjcm1dd7NUDijhcpE/aRDsGttNvyROOvrhJ9 30IzgGY1JttAov5z6EhibDjpo/tupSPk+aNlqaNDHKcXi+tbbpk8jatAFdfquUOhDH// FG0sCL2F0SHowsv61hCcFXAFtdzfZrFH2atcGV/XGpb713qXeZ3vIaNvU1b/yJOko5zG q9IQ== X-Forwarded-Encrypted: i=1; AHgh+RqWecLwJ2l0iXvMDD8snYvYbMOsHJ8ufNSMzUGz5AzB98SBH6mCr1mhMuW+yb13bjP59DEa9DxWiFWLgbY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3IUpdEA52QeRxVqvUYMAv8P56BoLTaduF5V4H/7Ys59CijJqp jtmstZ6h9JHHFznmyMTQlPdOJRDukZ41NUPZzf5AIEcRsTI+P9HRIFrcGODiYXPKjILKBxQwF9f DxD5SGsr1/MRByvd8HjVIDygCWcm7NLl8pbbSYLGWQULGxjM+zc2twRWdYK8W3ExDj4I= X-Gm-Gg: AfdE7ckqvdkkwmkPe1Apw1thi7mbEr53+nxdpOy2HsWOZbg5kj4dogN6rm4bZCRwfQE CJd/prS6yMEPDquIg6xXrMuG5cqOlyPnBa+We/y3r6FjBQfM64K8AnMwSPAnMq48RplN3Ltw5hQ Z0BxJj6oYzfjOr7CxZHGiwGRGI+YlS9Q90L5qIBDOOg0HbDbkNRZzLnHVg/3o3BXy9ORF/Bg6xz scjqOV5muirdHKdnRCOT/bBzeDyhfmDqykLge1UgqTiSZx/IcltDMw4sAC1xhqz05xgUCd9fqtX 6gdU8cnBOgxSt7Ty6MmhNyT4MXqdu5JQlvjV2h2ozIx+VmA3Dz0i8M9/8RJInuRDVQthiFRjHXg wiHvxvgBbsC7dgBEZMaJSHd08b9qzCSHKp25tapXMwclv80MhUg== X-Received: by 2002:a05:6a00:23c3:b0:845:d284:9e11 with SMTP id d2e1a72fcca58-84889756a2cmr15113948b3a.56.1784098731310; Tue, 14 Jul 2026 23:58:51 -0700 (PDT) X-Received: by 2002:a05:6a00:23c3:b0:845:d284:9e11 with SMTP id d2e1a72fcca58-84889756a2cmr15113930b3a.56.1784098730880; Tue, 14 Jul 2026 23:58:50 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f6c158bsm2585765b3a.38.2026.07.14.23.58.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 23:58:50 -0700 (PDT) Message-ID: <5612a63b-4052-41af-8676-9d92811dee9d@oss.qualcomm.com> Date: Wed, 15 Jul 2026 12:28:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260714145250.2473461-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260714145250.2473461-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260715-crafty-cheerful-goat-baba95@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260715-crafty-cheerful-goat-baba95@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ife3n2qa c=1 sm=1 tr=0 ts=6a572fac cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=LJDSKmyOq5XDa4FDNxEA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: ucEbW967GDChfkboCHUNyYwr0Gj7CIuT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA2NSBTYWx0ZWRfX1I6Oh5A0qdgc TiEO5SBIFk5425eb8zffgXTNoUSYg7uiTs41O/Y8MhpO+Xcm/lioONCtcN/mBjfVFfd+SePcQlN 6YU8U2ZTUnnx9kZiKaylFN30ankEjikomUyFKo886845ZHfAM/gyczay0p6hYL05k8fBllUd/v5 A4qtWQKoQvkcTbTFSKojy/nkcLUgJjd9t/tKk+3zezkkGYStllPn0tpDzOj34BzDxB7aSQ5bg7O BLREKo7pFDObLchRnOBl4xp0fK5oIDksrFXJkYMm7gaHdVrpxiyEd/eX1D3MHvI4YiKa002SPdA Gd8H+dDTRvD0Ac7o/47lv5pxsoZ0BFFy5awPkGQaxSTirTXErShzl7j3CIKGTlqGSrvSWANX4Xi tr+QQPIR6E3UOweyQmZygW+rGQsnxhq17BYK7AijYu1vqUNsaMBpWq/pATdk9FuBQeGpTOPGqjU bOdiRvywdGexZ36Q0ag== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA2NSBTYWx0ZWRfX0BeBMIN0tV0O +IlFc0gxlWHGYBaXw3YzH0ZW0UdBmyYxQxfLSvfn3TK5lxZu9iI5iY8+ZRkDScaOlVACunJvN4k jPvSzaAbpwovpmOcfyUOer00/g312dE= X-Proofpoint-GUID: ucEbW967GDChfkboCHUNyYwr0Gj7CIuT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150065 On 7/15/2026 11:35 AM, Krzysztof Kozlowski wrote: > On Tue, Jul 14, 2026 at 08:22:48PM +0530, Mohammad Rafi Shaik wrote: >> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >> describe Digital Audio Interface (DAI) child nodes. >> >> Add #address-cells and #size-cells to allow representation of multiple >> DAI instances as child nodes, and define a dai@ pattern to document >> per-DAI properties such as the interface ID and associated clocks. >> >> On platforms such as Monaco and Lemans, third-party codecs are hardware >> wired to the SoC and do not always have an in-tree codec driver to manage >> their clocks. For these designs, clock line enablement must be driven >> from the platform side, and this series provides the necessary support >> for that. >> >> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >> introduces the required device tree binding support to represent and >> vote for these clocks from the kernel. >> >> Co-developed-by: Srinivas Kandagatla >> Signed-off-by: Srinivas Kandagatla >> Signed-off-by: Mohammad Rafi Shaik >> --- >> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 89 +++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> index 2fb95544d..b37c62ccd 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> @@ -21,6 +21,82 @@ properties: >> '#sound-dai-cells': >> const: 1 >> >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> +# Digital Audio Interfaces >> +patternProperties: >> + '^dai@[0-9a-f]+$': >> + type: object >> + description: >> + Q6DSP Digital Audio Interfaces. >> + >> + properties: >> + reg: >> + maxItems: 1 >> + description: >> + Digital Audio Interface ID >> + >> + clocks: >> + minItems: 1 >> + maxItems: 2 >> + description: MI2S clocks (mclk, bclk and/or eclk). >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 2 >> + >> + allOf: >> + - oneOf: >> + - properties: > > Please don't do such stuff. Did you find it somewhere? If yes, then > where - so we can remove it? > It was not copied from another binding. It was my attempt to model the valid clock combinations. > I gave you the close-to-exact syntax I expect. It was nothing like this. clocks: minItems: 1 maxItems: 3 clock-names: minItems: 1 maxItems: 3 items: enum: - mclk - bclk - eclk The enum version does not enforce the positional relationship between clocks and clock-names, which is why I tried the oneOf approach. My concern with the suggested syntax is that mclk is not mandatory for all platforms. For example, HAWI only requires bclk and does not use mclk, so requiring mclk as the first clock-name would reject valid DTs. Is there a preferred binding pattern for expressing optional mclk while still preserving the positional mapping between clocks and clock-names? can you please suggest better approach to fix this if any. Thanks & regards, Rafi > > Best regards, > Krzysztof >