From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbbJEXt0 (ORCPT ); Mon, 5 Oct 2015 19:49:26 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:45542 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbbJEXtX (ORCPT ); Mon, 5 Oct 2015 19:49:23 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-f5-56130c80c117 Subject: Re: [PATCH 3/3] mfd: sec-core: Disable buck voltage reset on watchdog falling edge To: Bartlomiej Zolnierkiewicz References: <1443774351-28766-1-git-send-email-k.kozlowski@samsung.com> <1443774351-28766-3-git-send-email-k.kozlowski@samsung.com> <2375080.1KPJ21Fk4I@amdc1976> Cc: Sangbeom Kim , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Marek Szyprowski From: Krzysztof Kozlowski Message-id: <56130C7C.6000207@samsung.com> Date: Tue, 06 Oct 2015 08:49:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <2375080.1KPJ21Fk4I@amdc1976> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xq7oNPMJhBsvvy1hsnLGe1WL+kXOs Fq9fGFrc/3qU0eLyrjlsFjPO72OyWHvkLrvFxRVfmBw4PO5c28Pm0bdlFaPH501yAcxRXDYp qTmZZalF+nYJXBnPDt1lKnjGW9F2cR97A+ME7i5GTg4JAROJmx33mCFsMYkL99azdTFycQgJ LGWU2P9/MjOE84VRou3kBbAqYYFYibPNn5lAbBEBC4m1K96ywHXMeT0HzGEWuMYo0bB7MQtI FZuAscTm5UvYQGxeAS2JeTtuMILYLAKqEpcPXwGbKioQIXHq7FuoGkGJH5PvgfVyAtUfPXiL vYuRA2ionsT9i1ogYWYBeYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YW l+al6yXn525ihIT2lx2Mi49ZHWIU4GBU4uGVuCkUJsSaWFZcmXuIUYKDWUmE9yeXcJgQb0pi ZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGBevXGwU37Lwd/U/ j+wLySH/E9LZdkWe7tnw/sOFQ4/5Pdbven3zioPV6yM5zJJez7e2sjPt2+BamzRPsnra1YeG PC3SE9lf6XfsfiiTc1RjyrJFpz+aq8x9s0q2Mjjpe6iiD6fAOjn983Pldh1Kv21WKGU8MeG1 Ybmtxj6GXs2l65Nmc/lPfq/EUpyRaKjFXFScCACPXhAfaQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.10.2015 22:35, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, October 02, 2015 05:25:51 PM Krzysztof Kozlowski wrote: >> The WRSTBI bit (disabled by default but enabled by bootloader), when >> set, is responsible for resetting voltages to default values of >> certain bucks on falling edge of Warm Reset Input pin from AP. >> >> However on some boards (with S2MPS13) the pin is pulled down so any >> suspend will effectively trigger the reset of bucks supplying the power >> to the little and big cores. In the same time when resuming, these bucks >> must provide voltage greater or equal to voltage before suspend to match >> the frequency chosen by cpufreq. If voltage (default value of voltage >> after reset) is lower than one set by cpufreq before suspend, then >> system will hang during resuming. >> >> Signed-off-by: Krzysztof Kozlowski > > I tested this (with some additional Exynos5433 patches) and it works > like expected (suspend/resume issue is fixed). > > Tested-by: Bartlomiej Zolnierkiewicz > Thanks! > You could also add: > > Reported-by: Bartlomiej Zolnierkiewicz > > (since the issue got narrowed down and reported to you by me :). I didn't put it because I wasn't sure who was the author of our report. I'll wait a one more day for any comments and add it in v2/resend. BTW, any comments on the binding itself? Actually I had hard time choosing the name for binding because unlike the ACOKB the WRSTBI pin is not grounded but pulled down. However it is quite similar so I stick to the same convention: - samsung,s2mps11-acokb-ground - samsung,s2mps11-wrstbi-ground Best regards, Krzysztof