From: Guenter Roeck <linux@roeck-us.net>
To: David Cohen <david.a.cohen@linux.intel.com>, wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wdt: intel-mid: add Magic Closure flag
Date: Mon, 5 Oct 2015 17:21:00 -0700 [thread overview]
Message-ID: <561313EC.4060105@roeck-us.net> (raw)
In-Reply-To: <1444088998-20835-1-git-send-email-david.a.cohen@linux.intel.com>
On 10/05/2015 04:49 PM, David Cohen wrote:
> Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
> is opened, it makes sense to disable watchdog only if it was gracefully
> released.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Makes sense.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel-mid_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 0a436b5d1e84..db36d12e2b52 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
>
> static const struct watchdog_info mid_wdt_info = {
> .identity = "Intel MID SCU watchdog",
> - .options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
> + .options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
> };
>
> static const struct watchdog_ops mid_wdt_ops = {
>
prev parent reply other threads:[~2015-10-06 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 23:49 David Cohen
2015-10-06 0:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561313EC.4060105@roeck-us.net \
--to=linux@roeck-us.net \
--cc=david.a.cohen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome