From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbbJFOMZ (ORCPT ); Tue, 6 Oct 2015 10:12:25 -0400 Received: from 2.236.17.93.rev.sfr.net ([93.17.236.2]:26577 "EHLO mailhub1.si.c-s.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752132AbbJFOMX (ORCPT ); Tue, 6 Oct 2015 10:12:23 -0400 Subject: Re: [PATCH v2 13/25] powerpc/8xx: also use r3 in the ITLB miss in all situations To: Scott Wood References: <94728e239cad2224383db7ddc1c57df7d11561eb.1442939410.git.christophe.leroy@c-s.fr> <20150929000039.GG6161@home.buserror.net> Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org From: Christophe Leroy Message-ID: <5613D6C5.1030100@c-s.fr> Date: Tue, 6 Oct 2015 16:12:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20150929000039.GG6161@home.buserror.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/09/2015 02:00, Scott Wood a écrit : > On Tue, Sep 22, 2015 at 06:50:54PM +0200, Christophe Leroy wrote: >> We are spending between 40 and 160 cycles with a mean of 65 cycles >> in the TLB handling routines (measured with mftbl) so make it more >> simple althought it adds one instruction >> >> Signed-off-by: Christophe Leroy >> --- >> No change in v2 >> >> arch/powerpc/kernel/head_8xx.S | 15 ++++----------- >> 1 file changed, 4 insertions(+), 11 deletions(-) > Why is this a separate patch from 1/25? > > Same comments as on that patch. > > Just because here there is no real need behind the simplification of the code, whereas the first one was a pre-requisite for the following patch. Should I merge them together anyway ? Christophe