From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbJFOfu (ORCPT ); Tue, 6 Oct 2015 10:35:50 -0400 Received: from 2.236.17.93.rev.sfr.net ([93.17.236.2]:39260 "EHLO mailhub1.si.c-s.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752196AbbJFOfs (ORCPT ); Tue, 6 Oct 2015 10:35:48 -0400 Subject: Re: [PATCH v2 15/25] powerpc/8xx: move 8xx SPRN defines into reg_8xx.h and add some missing ones To: Scott Wood References: <20150929000346.GH6161@home.buserror.net> Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org From: Christophe Leroy Message-ID: <5613DC41.2000100@c-s.fr> Date: Tue, 6 Oct 2015 16:35:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20150929000346.GH6161@home.buserror.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/09/2015 02:03, Scott Wood a écrit : > On Tue, Sep 22, 2015 at 06:50:58PM +0200, Christophe Leroy wrote: >> Move 8xx SPRN defines into reg_8xx.h and add some missing ones >> >> Signed-off-by: Christophe Leroy >> --- >> No change in v2 > Why are they being moved? Why are they being separated from the bit > definitions? > > It was to keep asm/reg_8xx.h self sufficient for the following patch. Also because including asm/mmu-8xx.h creates circular inclusion issue (mmu-8xx.h needs page.h which includes page-32.h, page-32.h includes cache.h, cache.h include reg.h which includes reg_8xx). The circle starts with an inclusion of asm/cache.h by linux/cache.h, himself included by linux/printk.h, and I end up with 'implicit declaration' issues. How can I fix that ? Christophe