From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751464AbbJGHNH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Oct 2015 03:13:07 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:51958 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750824AbbJGHNE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Oct 2015 03:13:04 -0400
Subject: Re: [PATCH] iio: mxs-lradc: Fix temperature offset
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Marek Vasut <marex@denx.de>
References: <1444141347-15301-1-git-send-email-alexandre.belloni@free-electrons.com>
 <415576093.114803.1444157033983.JavaMail.open-xchange@oxbaltgw07.schlund.de>
 <561456ED.5010108@denx.de> <20151007004447.GC3485@piout.net>
Cc: Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org,
        =?UTF-8?Q?Janusz_U=c5=bcycki?= <j.uzycki@elpromaelectronics.com>,
        Jonathan Cameron <jic23@kernel.org>
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <5614C5F8.5020000@i2se.com>
Date: Wed, 7 Oct 2015 09:12:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151007004447.GC3485@piout.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:iGAyM/EJygnRklIvYhgjSeAkI2/rXhKuRwBbkOgPJWwLSevVqMD
 NS0QPUi30Egz+YRqwhVDOrN8Hz7mt+laJpfwuRAOV/PhtDTVjPSyR1LJTfGtnbpJyu9RQJK
 wc2zwQQAXZ4bvs45ZsOpiCrSLGTmB/c3jb8hxoS80c88swqNZPG/nSc3WuAy7StOfWeHxGR
 XiLtVTfuCsZlfjEgLTl3g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:nkQ6gymJt8A=:xnuEbJmNLGCEiCwFTVQXmV
 YpkltAJI7AmM8sbYgb8wxyNzhhxYNjIT+iVuNu1vYiF8t8Mz3Q5VGgsQ2NKgYwDx3VJ2vwetB
 mA//lGhO3tA1GjPh3Tw6n7/9rhjBZWwJOOq/sOxcSM5JDMc2Q6uMp9O9uAVxDTVcnXzhaCn2t
 yB9BnpeSPDAcICDVKTc1QG7hILbjtIO/jyV6wOtW3z+WvwkAJeLcQIuSXGLK26qV8d3tsr0lH
 2+XVTPa6v3QcCgfqLqv6n9VfAV2LRcPr2ppxP+zuHAOF7QpDm8qBrQOWSd/MsS9Q4//apDN3Z
 w2IS86zuxGRlo70JDHYQXXCWr541lDkpl/Iu13it1vusV75VmOf4iv6njWdtRDQW/qZVWw4xN
 vYL6sl/q9HbWrr5DEh0+vC/g8hEYcBE27XZU7XSmIAB+9YyhNn9Ur8RVSwDjFDHMUs/PtdEnU
 TlDiuxuxIfW9xwKPE/kQ6pwAdtRxud+7bPO9hwy4A0i3mHgnKbjeUtd+fgE1lz8M4tyG5k0VE
 L64K46QPpB5pjPH5GU76f5Z7naBFlcxKxTvLS60Uvlb1FMxidRWue/VPr0Pa7Pr/+EIjXJiaE
 6kFKwRozpv7/+2uHlqYY5qv4XoCu/3nJiWj5X7uZ+ctv3qAL1Bq/miGpe3ZDh2vptKkOmLjyN
 JTxVSx+ojWd/CrSmv/QUbH+LoBUr0l0aGYPsSHatIdKtcEkPqtX3vjSe33OHHK5sMZVZYB0sa
 ksgIlSHpjta2uGSr
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 07.10.2015 um 02:44 schrieb Alexandre Belloni:
> Hi,
>
> On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
>>>> /* The calculated value from the ADC is in Kelvin, we
>>>> * want Celsius for hwmon so the offset is
>>>> - * -272.15 * scale
>>>> + * -273.15 * scale
>>>> */
>>>> - *val = -1075;
>>>> - *val2 = 691699;
>>>> + *val = -1079;
>>>> + *val2 = 644268;
>>>>
>>> i think it would be nice to break down the calculation of these magic values in
>>> a second patch.
>> Indeed, I agree. I hope Alexandre can send another patch for that soon :-)
>>
> On my side, I'm not sure this is worth more than a comment. If
> necessary, I can write that the datasheet specifies that the scale is
> 4/1.012 here also.

I'm okay with that.