From: "Qing Zhang" <zhangqing@loongson.cn>
To: "Mark Brown" <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Xuefeng Li" <lixuefeng@loongson.cn>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>
Subject: Re: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
Date: Tue, 14 Jul 2020 20:16:13 +0800 (GMT+08:00) [thread overview]
Message-ID: <5614bc2e.1259.1734d41040f.Coremail.zhangqing@loongson.cn> (raw)
In-Reply-To: <20200714094406.GA4900@sirena.org.uk>
> -----Original Messages-----
> From: "Mark Brown" <broonie@kernel.org>
> Sent Time: 2020-07-14 17:44:06 (Tuesday)
> To: "Qing Zhang" <zhangqing@loongson.cn>
> Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, "Xuefeng Li" <lixuefeng@loongson.cn>, "Tiezhu Yang" <yangtiezhu@loongson.cn>
> Subject: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
>
> On Tue, Jul 14, 2020 at 05:09:14PM +0800, Qing Zhang wrote:
> > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> > calls as required by common clock framework.
> >
> > Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> > ---
> > drivers/spi/spi-coldfire-qspi.c | 4 ++--
>
> Are you sure that ColdFire uses the common clock framework?
>
> > drivers/spi/spi-omap-uwire.c | 4 ++--
>
> It makes life easier if you send per-driver patches, that makes it
> easier for driver maintainers to review things and means that issues
> with a change in one driver won't hold up another.
Hi Mark,
Thank you for your suggestion.
I will split this patch into two patches and then send v2.
</zhangqing@loongson.cn></yangtiezhu@loongson.cn></lixuefeng@loongson.cn></zhangqing@loongson.cn></broonie@kernel.org>
next prev parent reply other threads:[~2020-07-14 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:09 Qing Zhang
2020-07-14 9:44 ` Mark Brown
2020-07-14 12:16 ` Qing Zhang [this message]
2020-07-16 9:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614bc2e.1259.1734d41040f.Coremail.zhangqing@loongson.cn \
--to=zhangqing@loongson.cn \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®