From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C7E1C43334 for ; Fri, 15 Jul 2022 14:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235297AbiGOOnE (ORCPT ); Fri, 15 Jul 2022 10:43:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiGOOnB (ORCPT ); Fri, 15 Jul 2022 10:43:01 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24C1474DC2 for ; Fri, 15 Jul 2022 07:43:01 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id w16so2156502ilh.0 for ; Fri, 15 Jul 2022 07:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=xk8a+l++rWgkTq50yVGHgr4FTNm3uMWmqHNOlMKJ2yY=; b=irIFRF1PGBXVjKT0EyhMeBzL5zNDmcf66s6OkDheHVZQB2sAlNPjyphmxT8EzehMGm emD+ckTpKwGESRVErzWPSOFgBul4XR9AcSwF+cxbJCRCZZcy05kvoWkmdQAjfEQlZTiu QL+YvQyGVecx9suRhd8rf9xH6wrVLuodCn5dAgXiEWgjgEMY5nWvBirv6OZWKequkcdf XcOXwYaLnd47/88sJ9YyT4n9o7+XVrzfxKg5lK6DYIvNMDn5xZ/Y810rzxsdwWx+KsHf 6OXeleobam8ufdSfdGY7O6lAu/N4/xECWlaLPtY+V+KwR9TgnGXiVwVfgb1anPBe5Zhz hUIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xk8a+l++rWgkTq50yVGHgr4FTNm3uMWmqHNOlMKJ2yY=; b=FvzdMsKoYLVCM3MWJ6q0qmE3sL+VwqHhHE+E13myk0D5I/07zGdPU1quoJXwuIywes d9NGDIBRip4cpWw5LNgAuLtCuGhFfmrxfJtdYP/mgSq170QxDerbWWscAN6y1kYBMCMV UTC0SGvJt//7LCtsmD7Fp4w9rI3RLCNBYGrmMWZjvrTGhg58LLYWi2c/n5EYYEQrvv/8 G0yErNR798sOD2nfICQzOBG6x0JSUKitTL/K1NkGI05pdSVDamaX8GBoLHGdJHMm8rso iwIelvwD76Axl0UStVltk7bmTgPz0WLTP57FwK5rO+LP5mvXpbAnEP9i/wheJi1dzN2Z I/0Q== X-Gm-Message-State: AJIora+iOa+nJdSCBMZOdssjWHARKk+AbZVFVbYGh1WcRh2wkmDW/MW0 VFJFStfCGUCESu/geVCUq74syw== X-Google-Smtp-Source: AGRyM1vw6arlVWDR2sztJ/KCl9xkKybS345EYMCO/XurHiZLInhyDg7mRHdbJ9zCdNKHER8AmvDSkw== X-Received: by 2002:a05:6e02:4d1:b0:2dc:f85:2fed with SMTP id f17-20020a056e0204d100b002dc0f852fedmr7497276ils.94.1657896180444; Fri, 15 Jul 2022 07:43:00 -0700 (PDT) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id w4-20020a92db44000000b002db4e72ead5sm1760167ilq.50.2022.07.15.07.42.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 07:42:59 -0700 (PDT) Message-ID: <5614fbc0-509a-6341-bef2-8857f4fe610e@kernel.dk> Date: Fri, 15 Jul 2022 08:42:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: linux-next: build failure after merge of the block tree Content-Language: en-US To: Al Viro , Stephen Rothwell Cc: "Jason A. Donenfeld" , Ming Lei , Linux Kernel Mailing List , Linux Next Mailing List , Linus Torvalds References: <20220715140259.205ef267@canb.auug.org.au> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/22 10:10 PM, Al Viro wrote: > On Fri, Jul 15, 2022 at 02:02:59PM +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the block tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/block/ublk_drv.c:951:19: error: 'no_llseek' undeclared here (not in a function); did you mean 'noop_llseek'? >> 951 | .llseek = no_llseek, >> | ^~~~~~~~~ >> | noop_llseek >> >> Caused by commit >> >> 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") >> >> interacting with commit >> >> 8804bffa93a1 ("fs: remove no_llseek") >> >> from the vfs tree. > > I suspect that it would be a good idea to slap > #define no_llseek NULL > into include/linux/fs.h for the merge window, then remove it (and all > stray no_llseek initializers) at -rc1. Linus, would you be OK with > that approach? Not Linus, but I think that's a good idea as it'll reduce the pain for any new users added in other trees. -- Jens Axboe