mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@ezchip.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: error: implicit declaration of function 'zero_bytemask'
Date: Wed, 7 Oct 2015 09:29:28 -0400	[thread overview]
Message-ID: <56151E38.5030006@ezchip.com> (raw)
In-Reply-To: <87k2qyyh4x.fsf@steelpick.2x.cz>

On 10/07/2015 08:53 AM, Michal Sojka wrote:
> Dear Chris,
>
> the following commit breaks my Linux build.
>
>      commit 990486c8af044f89bddfbde1d1cf9fde449bedbf
>      Author: Chris Metcalf <cmetcalf@ezchip.com>
>      Date:   Tue Oct 6 12:37:41 2015 -0400
>       
>          strscpy: zero any trailing garbage bytes in the destination
>          
>          It's possible that the destination can be shadowed in userspace
>          (as, for example, the perf buffers are now).  So we should take
>          care not to leak data that could be inspected by userspace.
>
> The error message is:
>
>      lib/string.c: In function 'strscpy':
>      lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
>      cc1: some warnings being treated as errors
>
> I compile the kernel for PowerPC (32 bit) with the attached config.

Ah, it appears that big-endian powerpc does not provide
zero_bytemask(), only little-endian.  I'll fix this in v3 of
the patch series - thanks!

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com


  reply	other threads:[~2015-10-07 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 12:53 Michal Sojka
2015-10-07 13:29 ` Chris Metcalf [this message]
2015-10-07 13:41   ` Michal Sojka
2015-10-07 14:46     ` [PATCH] arch/powerpc: provide zero_bytemask() for big-endian Chris Metcalf
2015-10-08  3:39       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56151E38.5030006@ezchip.com \
    --to=cmetcalf@ezchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sojkam1@fel.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome