From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567AbbJGXwh (ORCPT ); Wed, 7 Oct 2015 19:52:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:56511 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbbJGXwg (ORCPT ); Wed, 7 Oct 2015 19:52:36 -0400 Subject: Re: [PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: James Bottomley , Tejun Heo , Hannes Reinecke , Johannes Thumshirn , Christoph Hellwig From: Lee Duncan Organization: SUSE Message-ID: <5615B03E.6080302@suse.com> Date: Wed, 7 Oct 2015 16:52:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Duplicate email, please ignore On 10/07/2015 04:47 PM, Lee Duncan wrote: > This patch updates the SCSI hosts module to use the idr > index-management routines to manage its host_no index instead > of using an ATOMIC integer. This means that host numbers > can now be reclaimed and re-used. > > It also updates the hosts module to use the idr routine idr_find() > to lookup hosts based on the host number, hopefully speeding > up said lookup. > > After noticing that my idr calling sequences where very close > to those in other modules, I considered creating some idr helper > functions (and using them), but because idr usage almost always > requires the caller to manage their own locks, I gave up on > this approach (as suggested by Tejon -- thank you). > > Changes from v1: > - no longer using helper routines > Changes from v2: > - added back missing scsi_host_get() in scsi_host_lookup() > > Lee Duncan (1): > SCSI: update hosts module to use idr index management > > drivers/scsi/hosts.c | 61 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 31 insertions(+), 30 deletions(-) > -- Lee Duncan SUSE Labs