From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbbJHGCr (ORCPT ); Thu, 8 Oct 2015 02:02:47 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34362 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbbJHGCn (ORCPT ); Thu, 8 Oct 2015 02:02:43 -0400 X-AuditID: cbfec7f5-f794b6d000001495-79-56160700f333 Subject: Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy) To: Marek Szyprowski , Greg Kroah-Hartman , Peter Chen , Ben Gamari , Wolfram Sang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <1444177807-15524-1-git-send-email-k.kozlowski@samsung.com> <56152BB2.4020202@samsung.com> Cc: Kevin Hilman , Arnd Bergmann , riku.voipio@linaro.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <561606FE.2090007@samsung.com> Date: Thu, 08 Oct 2015 15:02:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <56152BB2.4020202@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t/xy7oM7GJhBrNv8Fr8nXSM3WLW/Lss FvOPnGO1aF68ns3i9QtDi/7Hr5ktnm5+zGSx6fE1VovLu+awWcw4v4/JYtGyVmaLtUfuslsc m/2XyaLrXD+TxcoTs5gd+D1+/5rE6PHvcD+Tx6ZVnWwed67tYfPYP3cNu8fmJfUefVtWMXqc +e3scfLUExaPz5vkAriiuGxSUnMyy1KL9O0SuDK6Fm9kLvgiWHFxd1YD41K+LkZODgkBE4lP Ow6zQ9hiEhfurWfrYuTiEBJYyigx6dRrZgjnC6PE7I9zwaqEBfwlZiw9BZYQEZjKLPH/5Bem LkYOoKoMiUlTdUBqmAXiJG7v+McMYrMJGEtsXr6EDWKDnERv9yQWEJtXQEvi5L+jYDaLgKrE r68HweaLCkRInDr7lg2iRlDix+R7YDWcAtoSWz8tZgNZxSygLjFlSi7EKnmJzWveMk9gFJyF pGMWQtUsJFULGJlXMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoRE3dcdjEuPWR1iFOBgVOLh /WEsEibEmlhWXJl7iFGCg1lJhHfnfNEwId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwzd70PERJI TyxJzU5NLUgtgskycXBKNTAaqF94JJl57ey7rAkCuxbP8DCLOHBy4YT0GrFVauIrwxQvfH8j ynFu47/c90dT38cK5lg6ek2M/3hR3CUx0Tm6J3hpaG6gW/K6lX1LM5JEtz2b0vxCTHTRHKnH q12yZcKrhEO2xZ3i1pqwd+bjjtW3XnYfzfVoOc3mZRjW1v7m2OQz8k8Z5ocqsRRnJBpqMRcV JwIA52s2vLYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.10.2015 23:26, Marek Szyprowski wrote: > Hello, > > On 2015-10-07 02:30, Krzysztof Kozlowski wrote: >> Introduction >> ============ >> This patchset tries to fix probing of usb3503 on Arndale board >> if the Samsung PHY driver is probed later (or built as a module). >> >> *The patchset was not tested on Arndale board.* >> I don't have that board. Please test it and say if the usb3503 >> deferred probe >> works fine and the issue is solved. >> >> The patchset was tested on Odroid U3 board (which is different!) >> in a simulated environment. It is not sufficient testing. >> >> >> Difference >> ========== >> The usb3503 device driver can be used as a I2C device (on Odroid U3) >> or as a platform device connected through phy (on Arndale). In the second >> case the necessary phy reference has to be obtained and enabled. >> >> For some details please look also at thread [0][1]. >> >> [0] >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348524.html >> >> [1] >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348875.html >> >> > > I'm not sure that this is the correct approach. usb3503 chip is simply > connected > to Exynos USB2 phy, so it visible on the USB bus. The real driver that > controls USB2 > PHY is Exynos EHCI driver and USB3503 should not mess around it. The ehci node (usb@12110000) has one port configured and it takes one PHY reference (phy of id 1 - USB host). I can't see driver taking reference to HSIC0 or HSIC1 phys... Since I cannot diagnose the error I don't know what is really expected here. > > In my opinion all that is needed in case of Arndale board is forcing > reset of > usb3503 chip after successful EHCI and USB2 PHY initialization (for some > reason > initialization of usb3503 chip must be done after usb host initialization). > However I have no idea which driver should trigger this reset. Right now > I didn't > find any good solution for additional control for devices which are on > autoprobed > bus like usb. The reset is done at the end of usb3503's probe. The question "why usb3503 has to be initialized after EHCI and USB PHY" is still valid... Anyway thanks for feedback! I really appreciate it. Best regards, Krzysztof