From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757737AbbJIKhF (ORCPT ); Fri, 9 Oct 2015 06:37:05 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:56390 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757713AbbJIKhC (ORCPT ); Fri, 9 Oct 2015 06:37:02 -0400 Message-ID: <5617989E.9070700@huawei.com> Date: Fri, 9 Oct 2015 18:36:14 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kamezawa Hiroyuki CC: Taku Izumi , , , , , , Dave Hansen , Mel Gorman , Ingo Molnar , Subject: Re: [PATCH][RFC] mm: Introduce kernelcore=reliable option References: <1444402599-15274-1-git-send-email-izumi.taku@jp.fujitsu.com> <561762DC.3080608@huawei.com> <561787DA.4040809@jp.fujitsu.com> In-Reply-To: <561787DA.4040809@jp.fujitsu.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.561798B3.0060,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: edece1bf477ac73b29a5944f66fcfcdb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/9 17:24, Kamezawa Hiroyuki wrote: > On 2015/10/09 15:46, Xishi Qiu wrote: >> On 2015/10/9 22:56, Taku Izumi wrote: >> >>> Xeon E7 v3 based systems supports Address Range Mirroring >>> and UEFI BIOS complied with UEFI spec 2.5 can notify which >>> ranges are reliable (mirrored) via EFI memory map. >>> Now Linux kernel utilize its information and allocates >>> boot time memory from reliable region. >>> >>> My requirement is: >>> - allocate kernel memory from reliable region >>> - allocate user memory from non-reliable region >>> >>> In order to meet my requirement, ZONE_MOVABLE is useful. >>> By arranging non-reliable range into ZONE_MOVABLE, >>> reliable memory is only used for kernel allocations. >>> >> >> Hi Taku, >> >> You mean set non-mirrored memory to movable zone, and set >> mirrored memory to normal zone, right? So kernel allocations >> will use mirrored memory in normal zone, and user allocations >> will use non-mirrored memory in movable zone. >> >> My question is: >> 1) do we need to change the fallback function? > > For *our* requirement, it's not required. But if someone want to prevent > user's memory allocation from NORMAL_ZONE, we need some change in zonelist > walking. > Hi Kame, So we assume kernel will only use normal zone(mirrored), and users use movable zone(non-mirrored) first if the memory is not enough, then use normal zone too. >> 2) the mirrored region should locate at the start of normal >> zone, right? > > Precisely, "not-reliable" range of memory are handled by ZONE_MOVABLE. > This patch does only that. I mean the mirrored region can not at the middle or end of the zone, BIOS should report the memory like this, e.g. BIOS node0: 0-4G mirrored, 4-8G mirrored, 8-16G non-mirrored node1: 16-24G mirrored, 24-32G non-mirrored OS node0: DMA DMA32 are both mirrored, NORMAL(4-8G), MOVABLE(8-16G) node1: NORMAL(16-24G), MOVABLE(24-32G) > >> >> I remember Kame has already suggested this idea. In my opinion, >> I still think it's better to add a new migratetype or a new zone, >> so both user and kernel could use mirrored memory. > > Hi, Xishi. > > I and Izumi-san discussed the implementation much and found using "zone" > is better approach. > > The biggest reason is that zone is a unit of vmscan and all statistics and > handling the range of memory for a purpose. We can reuse all vmscan and > information codes by making use of zones. Introdcing other structure will be messy. Yes, add a new zone is better, but it will change much code, so reuse ZONE_MOVABLE is simpler and easier, right? > His patch is very simple. > The following plan sounds good to me. Shall we rename the zone name when it is used for mirrored memory, "movable" is a little confusion. > For your requirements. I and Izumi-san are discussing following plan. > > - Add a flag to show the zone is reliable or not, then, mark ZONE_MOVABLE as not-reliable. > - Add __GFP_RELIABLE. This will allow alloc_pages() to skip not-reliable zone. > - Add madivse() MADV_RELIABLE and modify page fault code's gfp flag with that flag. > like this? user: madvise()/mmap()/or others -> add vma_reliable flag -> add gfp_reliable flag -> alloc_pages kernel: use __GFP_RELIABLE flag in buddy allocation/slab/vmalloc... Also we can introduce some interfaces in procfs or sysfs, right? Thanks, Xishi Qiu > > Thanks, > -Kame > > > > > > > > > > > > > > > > > > > > > > > . >