From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB06423C8D5 for ; Fri, 12 Sep 2025 16:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757693063; cv=none; b=PR6B5RDuawAcSVHTmtwlUCWJTyaLi5JO5RBgWMpJO69xf49z8p3IM457MXSEIJCRTg4I0ewzcvu+SC0OOMLRyyr+9utS860+zFp4NlZH8Ud2HHvmVLTbQPjkFX1AZVXrmRz3mQYGeoE1lWVxvho2eXX/M43OlCd69b4Fgk6l4cU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757693063; c=relaxed/simple; bh=ofAxTBiqSJevq7WBibHDkBzcQFgGL2Zf4CkX37YCvUk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lCH9cN5pEPPhHi9sj9YXDBmW2GFydRl3hlix3+41YzVieL8FooYUpZEK+/mRsC6xLQTwEEuM3b9Ym0HLx0u2aZj3HOqDWzGDnQ4j7VtIcLJ770ZtRjbdb74NtH5bpRWh6n0nzGFXaMGqa3pqyWI2saVtViI3qgniFKpOo/bFdHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PPAOPSna; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PPAOPSna" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757693060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hG5/AZKn+Ejtcke6z1a0vOF9JLYUSlcjriPhjMOOTD8=; b=PPAOPSna/Vphay5ATaQYfO2jSWMemDzwZjKoOiF6GvFeAyE+AlwDHqDPaPeLGGMo+s0bYq FCPGUuI68xz03KZuWS/nkn9GCh5moa2gJjcE8r8/fa6zjg1KD0urcMlymMgpBJ3UpABIYW Ic9iMn2ZLJO44UK+fQzc4w6coB2vUN0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-W-EyL0OeMIOyghogFqX70A-1; Fri, 12 Sep 2025 12:04:19 -0400 X-MC-Unique: W-EyL0OeMIOyghogFqX70A-1 X-Mimecast-MFC-AGG-ID: W-EyL0OeMIOyghogFqX70A_1757693058 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3e751508f3aso1469905f8f.0 for ; Fri, 12 Sep 2025 09:04:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757693058; x=1758297858; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hG5/AZKn+Ejtcke6z1a0vOF9JLYUSlcjriPhjMOOTD8=; b=fdkLhRYKBj6frHkiHu5c1bezxGG95DNQHbDt+RiBinYwsdIEYm/5Manw8Gns2F87oC e0rIZAhLdHMgkdeI+Wz+l7tLLb+OVR+UxGp4wIdodQsy3CMTP3yEgIu3A6PyjJpHJr1S PUb2+bmQZBGBlg8ltZHMzlqf89arWB3jpfhHOJgiNOmp8rfqvJ9ot0DcVHebZPvhV3id yIKQa1C4mVEcMkfgswa6jqBM8aXhNQZK3tR9JD+Ayky1R3BQZkPnZt7XVfiHVEp9WOXA RW79Xm6nYK/T3jTTTDD25by74F0pexr/zkGPLsJOr4zVnx8Ar/d7/2oiSRlrVUAYXikn eLfA== X-Forwarded-Encrypted: i=1; AJvYcCX20bahA9WJl8kEiiDt5dQfW4zIJ2Q+jOdJpcSoYOTCqczJyhAcQV1va5PH42LwFXNhw7S1b9KRzsRj5I4=@vger.kernel.org X-Gm-Message-State: AOJu0YxaW60Vwl7dDHEnHdD3pFVtvjviB1WEXFC8oLNGMc9RgNYEbhwo 3WCgJ1rG+R5o+jQ8Hoag2DGJBW7+vVpcBATiPlo/mOaPi/FXZcqrcqaAxH8s5GN1lF/ynF3q34N GtSmrTBB9aiO69H0DtGnDxOQbw4kD/nkkRdnAme/JV4TamvDiPf06+ecjrEY89IdQlQ== X-Gm-Gg: ASbGncvDKwFKjolYhiyxb6xahPW94A2LGZbv6FjaH/JXk93PqyeWRZsiEwQ1sp8Xf9s N35UiSY6sjq+BmdrxQxdcsSItOz2bisJaTYiaBbeK6FMLakZh39bLfjWOUnsYYkmnt0pdg+3G/B 1O0DAoOS3yQDM760feFxM1nUtwoLfpK7YvTS+CnEhmV8w2w4FfexAyJKgVeGqIsO/1ctqVCoRWv ygC0b9eJ0ooSgN+eESLDqrKO+7J8gVU+3vKmFM71yxAv1MYrADod/46cry92nlNbIuKw3mFD4VH +Yad9r+TwqUcrHjZ9k/2K90QEuvjHMV5IcxGQSpYkGczA2TjMNzABAd0p79s6VEN9+muqLwWPaN XDy2l6ONzMP5BAGL+RwxuXAgUESXhZbVh36E9M3EWkNs9IKdEZEFkokxIPpQdj8L+O4s= X-Received: by 2002:a5d:588a:0:b0:3e2:b2f0:6e48 with SMTP id ffacd0b85a97d-3e7657830c7mr3389205f8f.1.1757693058038; Fri, 12 Sep 2025 09:04:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmTJGEBJ8Yi7y/CDniv/Cb2vtmWE7VSCvpdTGEnByD3ykpr0oRoFqb+KeFU7uief7Vv0aunw== X-Received: by 2002:a5d:588a:0:b0:3e2:b2f0:6e48 with SMTP id ffacd0b85a97d-3e7657830c7mr3389149f8f.1.1757693057182; Fri, 12 Sep 2025 09:04:17 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7d9844d24sm1148099f8f.46.2025.09.12.09.04.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 09:04:16 -0700 (PDT) Message-ID: <5617a501-3f46-423e-b3da-98efcd63d7c7@redhat.com> Date: Fri, 12 Sep 2025 18:04:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/15] mm, swap: always lock and check the swap cache folio before use To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Barry Song , Baoquan He , Nhat Pham , Kemeng Shi , Baolin Wang , Ying Huang , Johannes Weiner , Yosry Ahmed , Lorenzo Stoakes , Zi Yan , linux-kernel@vger.kernel.org, Kairui Song References: <20250910160833.3464-1-ryncsn@gmail.com> <20250910160833.3464-6-ryncsn@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250910160833.3464-6-ryncsn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.09.25 18:08, Kairui Song wrote: > From: Kairui Song > > Swap cache lookup only increases the reference count of the returned > folio. That's not enough to ensure a folio is stable in the swap > cache, so the folio could be removed from the swap cache at any > time. The caller should always lock and check the folio before using it. > > We have just documented this in kerneldoc, now introduce a helper for swap > cache folio verification with proper sanity checks. > > Also, sanitize a few current users to use this convention and the new > helper for easier debugging. They were not having observable problems > yet, only trivial issues like wasted CPU cycles on swapoff or > reclaiming. They would fail in some other way, but it is still better to > always follow this convention to make things robust and make later > commits easier to do. > > Signed-off-by: Kairui Song > --- [...] > index 4baebd8b48f4..f1a4d381d719 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -240,14 +240,12 @@ static int __try_to_reclaim_swap(struct swap_info_struct *si, > * Offset could point to the middle of a large folio, or folio > * may no longer point to the expected offset before it's locked. > */ > - if (offset < swp_offset(folio->swap) || > - offset >= swp_offset(folio->swap) + nr_pages) { > + if (!folio_matches_swap_entry(folio, entry)) { > folio_unlock(folio); > folio_put(folio); > goto again; > } > offset = swp_offset(folio->swap); > - Nit: unrelated change. Acked-by: David Hildenbrand -- Cheers David / dhildenb