From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305AbbJIPlR (ORCPT ); Fri, 9 Oct 2015 11:41:17 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:36647 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756941AbbJIPlE (ORCPT ); Fri, 9 Oct 2015 11:41:04 -0400 Message-ID: <5617e00e.0c5b8c0a.2d0dd.3faa@mx.google.com> Date: Fri, 09 Oct 2015 08:41:02 -0700 (PDT) From: Yasuaki Ishimatsu To: Xishi Qiu Cc: Andrew Morton , Yasuaki Ishimatsu , Mel Gorman , "David Rientjes" , Tang Chen , , Linux MM , LKML Subject: Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages In-Reply-To: <5615D311.5030908@huawei.com> References: <5615D311.5030908@huawei.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Oct 2015 10:21:05 +0800 Xishi Qiu wrote: > If kernelcore was not specified, or the kernelcore size is zero > (required_movablecore >= totalpages), or the kernelcore size is larger Why does required_movablecore become larger than totalpages, when the kernelcore size is zero? I read the code but I could not find that you mention. Thanks, Yasuaki Ishimatsu > than totalpages, there is no ZONE_MOVABLE. We should fill the zone > with both kernel memory and movable memory. > > Signed-off-by: Xishi Qiu > --- > mm/page_alloc.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index af3c9bd..6a6da0d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5674,8 +5674,11 @@ static void __init find_zone_movable_pfns_for_nodes(void) > required_kernelcore = max(required_kernelcore, corepages); > } > > - /* If kernelcore was not specified, there is no ZONE_MOVABLE */ > - if (!required_kernelcore) > + /* > + * If kernelcore was not specified or kernelcore size is larger > + * than totalpages, there is no ZONE_MOVABLE. > + */ > + if (!required_kernelcore || required_kernelcore >= totalpages) > goto out; > > /* usable_startpfn is the lowest possible pfn ZONE_MOVABLE can be at */ > -- > 2.0.0 > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org