From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdJFQA7 convert rfc822-to-8bit (ORCPT ); Fri, 6 Oct 2017 12:00:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48839 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbdJFQA5 (ORCPT ); Fri, 6 Oct 2017 12:00:57 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free() From: Kyle Fortin In-Reply-To: <20171005180920.GA121296@debian> Date: Fri, 6 Oct 2017 12:00:46 -0400 Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com Content-Transfer-Encoding: 8BIT Message-Id: <5619DDDF-453D-44DD-BDEB-B87DF0A18271@oracle.com> References: <20171005180920.GA121296@debian> To: Tim Hansen X-Mailer: Apple Mail (2.2104) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tim, On Oct 5, 2017, at 2:09 PM, Tim Hansen wrote: > > mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks. > > This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch). > > Signed-off-by: Tim Hansen > --- > block/bio-integrity.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/block/bio-integrity.c b/block/bio-integrity.c > index 5df3290..23b42e8 100644 > --- a/block/bio-integrity.c > +++ b/block/bio-integrity.c > @@ -485,11 +485,8 @@ EXPORT_SYMBOL(bioset_integrity_create); > > void bioset_integrity_free(struct bio_set *bs) > { > - if (bs->bio_integrity_pool) > - mempool_destroy(bs->bio_integrity_pool); > - > - if (bs->bvec_integrity_pool) > - mempool_destroy(bs->bvec_integrity_pool); > + mempool_destroy(bs->bio_integrity_pool); > + mempool_destroy(bs->bvec_integrity_pool); > } > EXPORT_SYMBOL(bioset_integrity_free); > > -- > 2.1.4 Looks good. Reviewed-by: Kyle Fortin