From: Hans Verkuil <hverkuil@xs4all.nl>
To: Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
"kernel-mentors@selenic.com" <kernel-mentors@selenic.com>,
Linux Media <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
m.chehab@samsung.com, khalasa <khalasa@piap.pl>
Subject: Re: H264 headers generation for driver
Date: Mon, 12 Oct 2015 11:47:32 +0200 [thread overview]
Message-ID: <561B81B4.1050305@xs4all.nl> (raw)
In-Reply-To: <CAM_ZknUEP73dQ2eEtVM_A_psAwcovKeiCDhpNgW+Fo96RRKM2w@mail.gmail.com>
On 09/29/2015 08:59 PM, Andrey Utkin wrote:
> This is a new chapter of tw5864 video grabber & encoder driver
> development drama.
> Last state of code is here (tw5864 branch, drivers/staging/media/tw5864):
> https://github.com/bluecherrydvr/linux/tree/tw5864/drivers/staging/media/tw5864
>
> Currently I use a third-side LGPL library for H.264 headers generation
> - SPS, PPS and slice headers (because device doesn't generate them).
> It is included as a git submodule "h264bitstream". It is used from
> tw5864-h264.c .
> Of course we want our driver to get to upstream repository when it
> matures enough, that's why we want to ask for advice regarding this.
> I see that there is no similar case in upstream kernel repo - no
> submodules and no libraries for H264 bitstreams.
> Device datasheet
> (http://lizard.bluecherry.net/~autkin/tw5864/tw5864b1-ds.pdf , page
> 47) shows that there's almost no variety of modes, so minimally an
> implementation of bitstream writing functions ue() and se() will
> suffice.
> I guess that one acceptable way is to pre-generate all headers for all
> needed cases and ship them inlined; for correctness checking purpose,
> it is possible to ship also a script or additional source code file
> which is able to generate same headers.
> Please advise.
>
> Thanks in advance for any kind reply.
>
You can do something like this:
drivers/media/platform/vivid/vivid-tpg-colors.c
Both the generated tables and the code that generates them are in one
file.
An alternative is to add a source to v4l2-core that generates the tables,
but I don't know if that is feasible (i.e., if it can be made sufficiently
generic).
Regards,
Hans
prev parent reply other threads:[~2015-10-12 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:59 Andrey Utkin
2015-09-30 9:55 ` Krzysztof Hałasa
2015-10-12 9:47 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B81B4.1050305@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=kernel-mentors@selenic.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome