From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932465AbbJMVXL (ORCPT ); Tue, 13 Oct 2015 17:23:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932325AbbJMVXI (ORCPT ); Tue, 13 Oct 2015 17:23:08 -0400 Subject: Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only To: "James E.J. Bottomley" References: <1441876994-16821-1-git-send-email-lvivier@redhat.com> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tyrel Datwyler , dgibson@redhat.com, thuth@redhat.com, pbonzini@redhat.com From: Laurent Vivier Message-ID: <561D7639.6030109@redhat.com> Date: Tue, 13 Oct 2015 23:23:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441876994-16821-1-git-send-email-lvivier@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James, this series has been reviewed and ack'ed, as SCSI maintainer, could you take it ? Laurent On 10/09/2015 11:23, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier > --- > I resend this patch as James was not cc'ed. > > drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c > index 6a41c36..3e76490 100644 > --- a/drivers/scsi/ibmvscsi/ibmvscsi.c > +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c > @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher"); > MODULE_LICENSE("GPL"); > MODULE_VERSION(IBMVSCSI_VERSION); > > -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR); > +module_param_named(max_id, max_id, int, S_IRUGO); > MODULE_PARM_DESC(max_id, "Largest ID value for each channel"); > -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR); > +module_param_named(max_channel, max_channel, int, S_IRUGO); > MODULE_PARM_DESC(max_channel, "Largest channel value"); > module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds"); >