From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754002AbbJNNpI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 09:45:08 -0400
Received: from mail-wi0-f172.google.com ([209.85.212.172]:36367 "EHLO
	mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753217AbbJNNpE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 09:45:04 -0400
Subject: Re: [PATCH] arm64: dts: mt8173: add MT8173 display PWM driver support
 node
To: YH Huang <yh.huang@mediatek.com>
References: <1444117243-28391-1-git-send-email-yh.huang@mediatek.com>
 <561BDA26.5010203@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
From: Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <561E5C5C.2080807@gmail.com>
Date: Wed, 14 Oct 2015 15:45:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <561BDA26.5010203@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 12/10/15 18:04, Matthias Brugger wrote:
>
>
> On 06/10/15 09:40, YH Huang wrote:
>> Add display PWM node in mt8173-evb.dts and mt8173.dtsi.
>>
>> Signed-off-by: YH Huang <yh.huang@mediatek.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8173-evb.dts |   13 +++++++++++++
>>   arch/arm64/boot/dts/mediatek/mt8173.dtsi    |   22
>> ++++++++++++++++++++++
>>   2 files changed, 35 insertions(+)
>>
>
> Applied, thanks.

I reapplied this on v4.4-next/arm64

>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> index 811cb76..1b3fabd 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> @@ -92,6 +92,13 @@
>>   };
>>
>>   &pio {
>> +    disp_pwm0_pins: disp_pwm0_pins {
>> +        pins1 {
>> +            pinmux = <MT8173_PIN_87_DISP_PWM0__FUNC_DISP_PWM0>;
>> +            output-low;
>> +        };
>> +    };
>> +
>>       mmc0_pins_default: mmc0default {
>>           pins_cmd_dat {
>>               pinmux = <MT8173_PIN_57_MSDC0_DAT0__FUNC_MSDC0_DAT0>,
>> @@ -190,6 +197,12 @@
>>       };
>>   };
>>
>> +&pwm0 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&disp_pwm0_pins>;
>> +    status = "okay";
>> +};
>> +
>>   &pwrap {
>>       pmic: mt6397 {
>>           compatible = "mediatek,mt6397";
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index 4bce167..fd01134 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -500,6 +500,28 @@
>>               clock-names = "source", "hclk";
>>               status = "disabled";
>>           };
>> +
>> +        pwm0: pwm@1401e000 {
>> +            compatible = "mediatek,mt8173-disp-pwm",
>> +                     "mediatek,mt6595-disp-pwm";
>> +            reg = <0 0x1401e000 0 0x1000>;
>> +            #pwm-cells = <2>;
>> +            clocks = <&mmsys CLK_MM_DISP_PWM026M>,
>> +                 <&mmsys CLK_MM_DISP_PWM0MM>;
>> +            clock-names = "main", "mm";
>> +            status = "disabled";
>> +        };
>> +
>> +        pwm1: pwm@1401f000 {
>> +            compatible = "mediatek,mt8173-disp-pwm",
>> +                     "mediatek,mt6595-disp-pwm";
>> +            reg = <0 0x1401f000 0 0x1000>;
>> +            #pwm-cells = <2>;
>> +            clocks = <&mmsys CLK_MM_DISP_PWM126M>,
>> +                 <&mmsys CLK_MM_DISP_PWM1MM>;
>> +            clock-names = "main", "mm";
>> +            status = "disabled";
>> +        };
>>       };
>>   };
>>
>>