From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984AbbJNOLs (ORCPT ); Wed, 14 Oct 2015 10:11:48 -0400 Received: from mail-db3on0087.outbound.protection.outlook.com ([157.55.234.87]:33408 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753919AbbJNOLo (ORCPT ); Wed, 14 Oct 2015 10:11:44 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH] fix return value error To: Leon Romanovsky , Heloise NH References: <1444810679-30592-1-git-send-email-os@iscas.ac.cn> CC: , , , , linux-rdma , "linux-kernel@vger.kernel.org" From: Or Gerlitz Message-ID: <561E5ED4.8000401@mellanox.com> Date: Wed, 14 Oct 2015 16:55:32 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.223.3.56] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD041;1:BEu44p+L7K4WT6UUzppcCWN1eWG40EiZrRS2kdUIjxvL4Dmvk7OlfRJYDYCLzXQFWDD4WuvjhAZ3RSAaKX4LPqAf2VFivdr8koCOoEBMwOOe6NqYD+xFGJ4GUQ4tiFQNMZw1vXaSA8F6D+RroIdddFzfn8pZ8FPT9nMEvheiD8mzNdKTG59Yxc60Bxbdofy3tjm2lRyKjPccL3mCa5YdjSc00hc7OWxUPxhCZIxSUGu8s1i7Zrxr3TcbJ+Yx4jAsnJ9WY1SDr61vxZkP+dyvcMYNjgnlu8m1DCN7jjcF4GgX/2D94qje8NM6Rt72nr63ce3RB5Jm1BM1gQdLWhIk7K5Z4CyvCuLqVpin/jjAwUKLLs7tHJj5X2FGCdMaUzEsoASyjbK0YrCo/Tdp+8XFJQ== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377454003)(189002)(24454002)(199003)(479174004)(5001770100001)(97736004)(64126003)(19580395003)(87266999)(65816999)(106466001)(80316001)(4001350100001)(47776003)(5008740100001)(23676002)(86362001)(5004730100002)(87936001)(76176999)(54356999)(11100500001)(189998001)(5007970100001)(77096005)(65806001)(59896002)(83506001)(46102003)(19580405001)(50986999)(65956001)(92566002)(50466002)(33656002)(64706001)(6806005)(36756003)(2950100001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1468;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1468;2:tcnqjWcv94lf+0GGqHC2FImPBQTZeTY9Y4lcjOlGnkW7cKjdMhahfcCx3wcuY+jsPO2DZfdKkfLoGc3pnDt22fIDerWYr5RtTdJBZ/FuNI6crrpsfgF59P2uYqV9DAjYm9CoB3mOwc+nV3s1a1bQw38TgJSe4teWWdzdOlii0B0=;3:5pyDz6XCcUjTws+Fvu1FAGNfAZbAlDRp6e3p+D8yJO/9QOrCeMCgGCx+gUP6w+DDL5OkTagLhykK47pIF4fafMrJKisWY9xZsB0FqLn3Htr21vN07jhDvkt6nDLvFvnISmwuheJP4qi/HIUsc8S6P4meS4qhf1rkMrgqj7+RAkEKMpiU4rilN78BVTrKYa+Mt5PHOZZwoXplZxXbjRBKOS+zt8+qpH7tJr2IxF9j5i5Awa61LTq7icFDQlxnP/QMgO3dDyAn9L0mR5ZgqrQugw==;25:GvMoC2mLeIm9w4dn8L6iY76y5bAt+oi85zycR+/VZkgdtKYN29IwFOyaeRbh61nVufGU0KYVR+0+i32tTSxbgpwbkW0WETyt8L2UmynnweKnK2MsR4LTd4FYSlEwIm74Mp2voFzSZOuVM2tkPkY8rdZnhqNP1Hn2BhC5pig5jLAQSGMBZCBOuia79UHNfG/NYAssNHwTWVtuYTdJO1bJzbz8Vuz8pgecgNRlzrxow7npHxZkT43wnesdJ0JsDEyFWqiLQdJEVjoa2oX4BKP+wA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:HE1PR05MB1468; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1468;20:Acu0qK9Eg9DcByeNd5j1RUsfmhpriDzepkVZ8Yd+jC/y981yXnMnfJ8WQSBHYYEiPbGJMBOPcSL/YdUxux7SXfJN9mtDLKvcljSzkFDTz72NxTIRNjh/Wtb0igcP83usdcYvorkAl4T+xeZee55njAhR+Q8bpzKaK8L/klpXb6VcqZZFA9N4x9622WIt4Nja5KrQBc+J8gPEbEYA1mIdpk9ZxzK8ivkEG5E4Xn9GITDYl/hlu5jO2up5BxYnkPgYdtEbd2djLU1ETvr/hlh69pQeKI7+M6RbLoKU6d1w+JFwzg7BrXkhqz6eF9BXN1ml9EnGQiwcvpLaR14va7GveUoePCaNmcJtv4xbnp3XI0qkQCScH0orD2bVWgkaFjm20ZqwuXIofVNHxyUgIIr9s6axgjSLTVkMRM4AVfmyfeBEKO2wetEWCvCzE9irgjcTy7/xgJN/meyEblrXupzSTGNRM52R+GyXdfumtCWxwtZbCKVJibIYeMvsntsv26F6;4:mzTPODtwFhfgp+CJ6EHKZ7VbwBpfazxg1XYtmjgJOvjaVtDkYgISRF8hFZGU/MJEXwRBNOoN1/KuJGARK9V3UQV38ZVTgPBZqN5VL94PXLKKOmKTMaxZt23/FH7xl9DRdlEzHprdNVhuyymTJfBWT5PJIOsZsRZv6sZ0kXw6vtkDVGQ67mVKNA3puIGzHqKPEsuZReqWpo8i3f851ho3n8OEWhbOVkKgMzqfrApqLYqcZUOacGp1e6wanSgOamCgBY8n2wf3hC1dX704n9le0dsefg4QMshaHdyAh7PHwJa8gmPp4TxTUEVqKuwKB64nGMmcQkcU00h2ByjaSLFzPT+HAYsRBEp/ZMqs8rUKZrM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:HE1PR05MB1468;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1468; X-Forefront-PRVS: 0729050452 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1TUIxNDY4OzIzOmhFVDJRNFhaS3hyVnMwTWNlOEtac0NzZzdR?= =?utf-8?B?QUdidzlKQW02eTJNa3BsR3Arak5Fc09DM1ptczZWOXc0ZEhsVU1Ib3dFTFFF?= =?utf-8?B?M213UEh6Y2xrS2lXa1JxdXJ3OTRYLy9QYlFwNk02bk81Q1duQnhaQWhEM3Bm?= =?utf-8?B?K3JqZ0JoMTREbm02QUlOdjE3MXJkVmUyTEZ2QVBVeVZ5OVdya1dESGFmd3lk?= =?utf-8?B?UTlGUk1odlc5L01mZVk2Y1lZKzQrdmhZNEVDWUtDLzNvVnRSZ1NUM1RyV1Zp?= =?utf-8?B?M0tkTTFRMDM0eGowekRuTmNSb2Nja1FWNFROeWRmNWkyWmlCTFRSM3BoT0dP?= =?utf-8?B?bjNNbU45RXFuVzU4QWJxMlEyUm9ISEsrSmJYTVhhNDkzNEF2Y3hoN3RuR3Nt?= =?utf-8?B?K0hXdW15NGFPVi95WUpzZHdoWHhWV09NTWhCc1lGd0twczIvSndyenZQdVNL?= =?utf-8?B?SFFjTzZBVkNzY0dnL0R5a1lCNkQzVnBzU08zMFkwZUZQSytCeUpoUEplTDc0?= =?utf-8?B?MTMramZyN1FiYXRML01NNHdQcWo2K2pYVjU2VDdnUlJBamp5cWFwaDBIUGo3?= =?utf-8?B?Nk1YMzhVZXIzWkpVZDJxNG53OHB0WlRGbUE2dHpQU0RlWkx4bTRPa2xMcFVz?= =?utf-8?B?NmR6aUQ1QlYxellTbnVtN0J5VGkvdFRydkladlBVRFlFVlNNdGlRRTZuSG01?= =?utf-8?B?d052RDJObkpzLzF4eWIyL2h0cWtkUlZOVG1aMHVKRmZTem04bExzWWx3OGdO?= =?utf-8?B?WFg5OEZNT2hBNVdRck9JU3pYMERETEo4OGRYUnVPRnpFd3NFLzNPQXd3ZGFE?= =?utf-8?B?OVhzUVViL1hvTnNyRktMOWluTFpobmk2VlF3dlVtWk52MFVBSmpXV1FGa1lY?= =?utf-8?B?YmtNS0habWpPL1kvV0syazBYZnkwdzlUTUllVTNuK3dLZVRBVWtCcW1CNDhP?= =?utf-8?B?azNkRnVpemFhTGJIOGJzTmhXZHRRVmNRTnFJb0RvSnNVa1lkWjUyNHZ4QVpw?= =?utf-8?B?aUxPSnYvRTk1dnVIOFJnTkwwd2hhMGRZNlFtOXIwU1VvTUZ0dHNsOHNGYjdH?= =?utf-8?B?VEFTUUp5RmozVmhSSXJjbFhnTkFPWnVJYWxKU3g2TVY3dzR2cncwWkc1d2VC?= =?utf-8?B?eUR5TVcrMDNJbnJ2RjZQa0JLektKRlNsRmxOa3JUUE9CZnZlNWtnT0VxMXlu?= =?utf-8?B?cUxsNk1kQzh2djRFQ3h4UUJPd0VQL3VOM1I0TnJGTGpCb2ZGUk1MWnBiN1Ra?= =?utf-8?B?YTRLNkEvU2Y0VXgvTWpqbWVCRGtXUzVlcFlZWURpc3kva25zVThXb3BMVktt?= =?utf-8?B?UmdOMHZmYXFQT0tTRE5SRENZSmZFZkN5azF6T1RkbWcxTFlzalg2bjNUS3gv?= =?utf-8?B?RHBraWkrZ1hjNENGRXRlcStoUVJtVFpoMHFBT3UydlJUTk1aQlozTDJ6Z3di?= =?utf-8?B?MDBCckhTVEhWWHorcXdnZVVxMW93WWpkR2tKM09DaExvSlhwOUZ2ekh6TFFn?= =?utf-8?B?ak5sU0gwdUFMMkVkSkVhOWNXeHVVbzBaWDNmaWNpSXNia1NGSUZZQ0NNdm8y?= =?utf-8?Q?mqgNTPka8QZuH5S389YQ5S9wyE+6raSbBpe2ZTaCwZT4=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1468;5:bD+y6hfHZG00yuoh/LdxCB7VCEeoUAm03iQCMbrMyWtY597CYuvXCOU1R1IN1/S83uQlYm1UWBreUJCTaC6fU4/le5fiI9XAxGS55r7TL7CvF898HmY1QxEhWN2f0H0Q44MjOnAEngn3aAhpu0DVBQ==;24:ix3eWynPTqz8CMb/Rse4R3UajIDANZGUb9eh0MA0fTYUVKC9Ky+M/kAGXoa9QZCtuli7274HuRFqZTToZTC/z12pMHpgkxuUliPGYCISUyI=;20:LCQ0ZXJ536fnh4+6tR+f1Fh1qWB+2CrZ3Hf5BdaoKzgAM4VptL7nxvON+7Wuau0Quah9/9ggOXWx4Evs9qyJrg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2015 13:56:26.3233 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1468 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 2:59 PM, Leon Romanovsky wrote: > On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote: >> >Signed-off-by: Heloise NH > The patch is a correct one, however can you update the subject and > description to be more informative? > Please add that new_inode() function can fail for allocation only. > >> >--- >> > drivers/infiniband/hw/ipath/ipath_fs.c | 2 +- >> > drivers/infiniband/hw/qib/qib_fs.c | 2 +- NO... the ipath driver has moved to staging as part of its EOL process, it's now under drivers/staging/rdma/ipath