From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbbJNOS0 (ORCPT ); Wed, 14 Oct 2015 10:18:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:58077 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbbJNOSW (ORCPT ); Wed, 14 Oct 2015 10:18:22 -0400 Message-ID: <561E642D.8080407@suse.de> Date: Wed, 14 Oct 2015 16:18:21 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Johannes Thumshirn , "James E.J. Bottomley" , Christoph Hellwig CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] SCSI: Rework list handling in scsi_target_remove References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 03:50 PM, Johannes Thumshirn wrote: > Rework the list handling in scsi_target_remove(). The new version introduces a > reap list for targets. Targets that shall be removed are placed on the reap > list and can then be reaped later on. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/scsi_sysfs.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index d7afea9..b41dcb3 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -1156,31 +1156,28 @@ static void __scsi_remove_target(struct scsi_target *starget) > void scsi_remove_target(struct device *dev) > { > struct Scsi_Host *shost = dev_to_shost(dev->parent); > - struct scsi_target *starget, *last = NULL; > + struct scsi_target *starget, *tmp; > unsigned long flags; > + LIST_HEAD(reap_list); > > /* remove targets being careful to lookup next entry before > * deleting the last > */ > spin_lock_irqsave(&shost->target_lock, flags); > - list_for_each_entry(starget, &shost->__targets, siblings) { > + list_for_each_entry_safe(starget, tmp, &shost->__targets, siblings) { > if (starget->state == STARGET_DEL) > continue; Hmm. This can even be converted into a WARN_ON(), as with this patch there should _never_ be an deleted target on the list. Other than that: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)