From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932670AbbJNPUm (ORCPT ); Wed, 14 Oct 2015 11:20:42 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:61680 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932472AbbJNPUl (ORCPT ); Wed, 14 Oct 2015 11:20:41 -0400 Subject: Re: [PATCH v2] nouveau: fix OpenFirmware support To: Ilia Mirkin , Olaf Hering References: <1444574882-3565-1-git-send-email-laurent@vivier.eu> <20151014142000.GA16845@gmail.com> Cc: Dave Airlie , Ben Skeggs , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" From: Laurent Vivier X-Enigmail-Draft-Status: N1110 Message-ID: <561E72BD.8010208@vivier.eu> Date: Wed, 14 Oct 2015 17:20:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:CQRHrnoTmBEXHW9PlqxxYlHGdrhPRXENLO6ollpfH9wrE/6Kcf/ IdJLCj7NV+IUMEKlpNcSmT4UD5keak7drSWYTm7VRYvc4AJBaNFCxLD+wFTTpll/M7oufxc zOeL/0QwaS+lMkXLgoIOpZutIFusb2UQcf7XPuTUw1bn0z6v0iucqmOhIeuXTpYZfQIr4be YsHymg17rkAn/fbwENdmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0KAvVyVFfvw=:XvkbAePNAwDvJASYkh9d8Y 4yOuss+J3p8OOB0cKE6F86ilmwwRAeqn0VDI7HAnYqQ2I/Dayu2rijlRuT8HjbKnPssrI+FWa LZe/PEAB0WWdl/ZAa0XACRonBX08isR/CcFES6yUtVnSp31uQwQYGQBia66uRhCN93H2XMa2u 5AdOZvlFEwGpBIw5MUEZGg8qp1J4EkYC2/808DjALKLzWSYZhqVr6554GFa0z9r0nmafjm71D A5K3asGFPCYmO8a+Qata6UiJRyKHox0UuNRLsIY4jLkzzkPDctSqUBGAG1xMaKpqtQj0mEAIN 3XeLb4gVFpM/9BT69HOxbfgOqSUeQrDCWyNStdEl0yfjua9MseKkFQ97AfTj4vLHwzpeZgzGS kCLWaMkMV2CYQa/muHsUwl8KrjEkVqWdhOVthq/I0Tjh4C+uOZZqV/2wb13Qnoj0uG5JArvYP wJ6Td+DmT/u3oM8GJ2QCythZfQTlHaERoUdf0+GbJXThR9KWMpmo4g6DDgyyh1PlEJmfqkp0j nLeel/idI6CVGEckEmTn022SAz9XaqzcxsJeVpt+j5KfH+XWFLn1i2W9YaGC0b0sTTbz1fdu/ uIBTNSw4x/ZuX3GdH3j7XdcoSHgLHmemnDTh3LyZrRmAON81Pq/Qwzypnu7h7OgGAQOBrtPQr T9SVv+gztD7E/89mo9AwqEjHPZPPOBTwD1/vv1XoQ88viVybnQPTrr0UG0cSJZ/KZ8bcKwzxQ Cd40HIwutJcLKPsa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 14/10/2015 16:52, Ilia Mirkin a écrit : > On Wed, Oct 14, 2015 at 10:20 AM, Olaf Hering wrote: >> On Sun, Oct 11, Laurent Vivier wrote: >> >>> On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp() >>> returns NULL. But in fact the OpenFirmware has given us the size >>> we can store in image->size. >> >>> CC: imirkin@alum.mit.edu >>> Signed-off-by: Laurent Vivier >> >> Tested-by: Olaf Hering >> >> Broken since a while already... >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-March/126737.html > > FTR, looks like my version is upstream now: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=25d295882a1adfcdaaad85369289677b87c7c8f0 > > I agree that my of_size thing was a bit of a hack, if you want to redo > it by removing of_size/of_read from shadowof.c and copying it in at > init time (also a hack, IMHO), I certainly wouldn't object. As before, > it's Ben's call though. It's nice to have a fix upstream. I'll send a patch to remove the of_size. Rereading your patch and mine, I think we don't need no_pcir, we can do instead: if (!nvbios_rd16(bios, base + 0x18)) { /* no PCIr */ image.base = 0; image.type = 0; image.size = bios->size; image.last = 1; } else { if (!shadow_fetch(bios, mthd, offset + 0x1000)) { ... What is you opinion ? Laurent